Review main Merged

60419[FEATURE] Allow config.cache.all = fe_users:current

Benni Mack CR +2 V +2 Easy +41 −2 updated 04/11/19, 23:50

Commit message

The existing TypoScript functionality config.cache.all = ... allows a list
of tables and PIDs to take into account other records for the current page
caches.

The cache lifetime of page 42 takes starttime and endtime of news records of
page 15 and addresses of page 16 into account:

config.cache.42 = tt_news:15,tt_address:16

A new functionality used with "current" allows to take records of the current page
into account as well.

config.cache.all = fe_users:current

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Fabien Udriot +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 04/09/19, 01:52

  2. TYPO3com voted on patch set 1 V -1 04/09/19, 02:10 Completed build in 17m 46s on Tue, 9 Apr, 04:10 AM Test Summary: 1 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33124

  3. TYPO3com voted on patch set 1 V +1 04/09/19, 02:34 Completed build in 59m 35s on Tue, 9 Apr, 04:34 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33124

  4. Jörg Bösche commented on patch set 1 CR -1 04/10/19, 12:59

    Feature-83734-AddSupportForCurrentPageInConfigcache.rst:19

    Do you want to use "this" or "current"? Code example is this, instead of current, vice versa. Would prefer "current".
  5. Benni Mack commented on patch set 1 04/10/19, 15:22

    "current" is more appropriate. Care to update the patch? Would appreciate this!
  6. Jörg Bösche uploaded patch set 2 04/10/19, 16:04

  7. Jörg Bösche uploaded patch set 3 04/10/19, 16:07

  8. TYPO3com voted on patch set 2 V +1 04/10/19, 16:20 Completed build in 15m 59s on Wed, 10 Apr, 06:20 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33184

  9. TYPO3com voted on patch set 3 V +1 04/10/19, 16:23 Completed build in 16m 10s on Wed, 10 Apr, 06:23 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33185

  10. Georg Ringer voted on patch set 3 V +1 CR +1 04/10/19, 19:03

  11. Benni Mack commented on patch set 3 04/10/19, 23:48

    Jörg, feel free to vote!
  12. Jörg Bösche voted on patch set 3 V +1 CR +1 04/11/19, 06:32

  13. Fabien Udriot voted on patch set 3 CR +1 04/11/19, 08:04

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/11/19, 23:50

  15. Benni Mack merged patch set 4 04/11/19, 23:50