Review main Merged

6042[BUGFIX] Add default csc-mailform DIV wrap

Oliver Hader CR +2 V +2 Easy +19 −3 updated 06/03/13, 20:49

Commit message

A new form element does not have any class settings. This issue
reintroduces stdWrap possibilites for the new form system extension.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Steffen Ritter +1
    • Xavier Perseguers +1
  • Verified V +2
    • Oliver Hader +2

Files 2

Review log 12

  1. Oliver Hader uploaded patch set 2 10/23/11, 17:42

  2. Oliver Hader commented on patch set 2 10/23/11, 17:42

    I would prefer that you didn't submit this Will modify again... on checking again I discovered a security issue that has been introduced with this changeset.
  3. Oliver Hader uploaded patch set 3 10/23/11, 17:42

  4. Oliver Hader commented on patch set 3 10/23/11, 17:42

    @Helmut: Can you please double check the new stdWrap possibility concerning security issues? Thanks!
  5. Oliver Hader commented on patch set 3 V 0 10/23/11, 17:42

    by team member; Looks good to me, approved As discussed with Xavier, we're going to merge it for 4.6.0
  6. Xavier Perseguers commented on patch set 3 10/23/11, 17:42

    Looks good to me, but someone else must approve
  7. Georg Ringer commented on patch set 3 10/23/11, 17:42

    Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 3 10/23/11, 17:42

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 10/23/11, 17:42

  10. Mr. Jenkins commented on patch set 2 10/23/11, 17:42

  11. Mr. Jenkins commented on patch set 3 10/23/11, 17:42

  12. Oliver Hader merged patch set 3 10/23/11, 17:42