Review main Merged

60430[BUGFIX] Add table name as prefix for language DB selection

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/10/19, 19:04

Commit message

When building JOINs with TypoScript of tt_content or
any localized table, using "LEFTJOIN tt_content table2"
the language restriction check is not using a prefix
for the "l10n_parent" field.

The "sys_language_uid" field already has the same prefix
built in the same method.

This error existed in v8 already, but in TYPO3 v9, the
"includeRecordsWithoutDefaultTranslation" option is enabled
by default (via LanguageAspect), therefore it's more
prominent.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Julian Geils +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Julian Geils +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/09/19, 12:45

  2. TYPO3com voted on patch set 1 V +1 04/09/19, 13:01 Completed build in 15m 36s on Tue, 9 Apr, 03:01 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33139

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 04/10/19, 12:47

  4. Julian Geils voted on patch set 1 V +1 CR +1 04/10/19, 12:47

  5. Georg Ringer voted on patch set 1 V +2 CR +2 04/10/19, 19:03

  6. Georg Ringer merged patch set 2 04/10/19, 19:04