Review main Merged

60431[TASK] Write cleaner FileWriter JSON output

TYPO3com CR +2 V +2 Easy +23 −1 updated 05/31/19, 10:58

Commit message

Since PHP 5.4 it's possible to disable escaping for unicode characters
and slashes, which results in a much cleaner, leaner and most
importantly readable TYPO3 log output.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Tomas Norre Mikkelsen +1
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1216

  1. TYPO3com uploaded patch set 1 04/09/19, 13:30

  2. TYPO3com voted on patch set 1 V +1 04/09/19, 13:45 Completed build in 15m 16s on Tue, 9 Apr, 03:45 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33143

  3. Jörg Bösche uploaded patch set 2 04/10/19, 07:39

  4. TYPO3com voted on patch set 2 V +1 04/10/19, 07:51 Completed build in 12m 23s on Wed, 10 Apr, 09:51 AM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33157

  5. Markus Klein voted on patch set 2 CR +1 04/10/19, 11:13

  6. Tobi Kretschmann voted on patch set 2 CR +1 04/12/19, 08:53

  7. Oliver Klee voted on patch set 2 CR +1 04/12/19, 10:49

  8. Guido Schmechel commented on patch set 2 04/13/19, 21:04

    Can we add support for 9.5, too?
  9. Markus Klein updated the commit message in patch set 3 05/06/19, 21:05

  10. Markus Klein voted on patch set 3 CR +1 05/06/19, 21:06

  11. TYPO3com voted on patch set 3 V +1 05/06/19, 21:18 Completed build in 13m 21s on Mon, 6 May, 11:18 PM Test Summary: 47479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33749

  12. Oliver Klee voted on patch set 3 CR +1 05/07/19, 12:34

  13. Georg Ringer voted on patch set 3 V +1 CR +1 05/11/19, 05:31

  14. Tomas Norre Mikkelsen voted on patch set 3 CR +1 05/13/19, 18:31

  15. Frank Nägler voted on patch set 3 V +2 CR +2 05/31/19, 10:57

  16. Frank Nägler merged patch set 4 05/31/19, 10:58