60432[BUGFIX] Fix handling menuConfig of LanguageMenuProcessor
Commit message
Review
-
Code review CR -1 Done
- Richard Haeser +2
- Björn Jacob +1
- Benni Mack -1
-
Verified V +2 Done
- Richard Haeser +2
- Benni Mack +2
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 89
-
Daniel Gohlke uploaded patch set 1 04/09/19, 14:49
-
Björn Jacob voted on patch set 1 V +1 CR +1 04/09/19, 14:52
-
TYPO3com voted on patch set 1 V +1 04/09/19, 15:04 Completed build in 15m 21s on Tue, 9 Apr, 05:04 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33145
-
Richard Haeser commented on patch set 1 04/09/19, 15:06
Let me think about this one. By removing a parameter, you also get another hreflang link which might not be right. -
Benni Mack voted on patch set 1 V +2 CR +2 04/09/19, 15:17
-
Benni Mack commented on patch set 1 CR -1 04/09/19, 15:17
waiting for Richard's final call (feel free to merge Richard) -
Richard Haeser commented on patch set 1 04/09/19, 18:31
This situation is not ideal from a SEO perspective. The current situation is however not ideal as well in this situation. I will add a new feature to make it possible to disable the hreflang on certain pages, because that seems the best option on those pages. From an UX-perspective having this option is a step forward, so I will check this patch and will approve it when it works. -
Richard Haeser voted on patch set 1 V +2 CR +2 04/09/19, 18:42
-
Richard Haeser merged patch set 2 04/09/19, 18:42