Review main Merged

60433[TASK] Unify Backend Route paths for modules

Benni Mack CR +2 V +2 Normal +54 −2 updated 06/26/19, 04:32

Commit message

Modules which do not set a proper route path themselves
now have a different route path, basically "/module/file/list"
for example, whereas there is a proper prefix with
"/module/" and no trailing slash anymore.

It is still possible to build links to the route paths,
and resolve them properly.

The "old" route paths will stop working in TYPO3 v11.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Benni Mack uploaded patch set 1 04/09/19, 15:34

  2. TYPO3com voted on patch set 1 V -1 04/09/19, 15:49 Completed build in 14m 59s on Tue, 9 Apr, 05:49 PM Test Summary: 32 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33146

  3. Benni Mack uploaded patch set 2 04/17/19, 20:10

  4. TYPO3com voted on patch set 2 V +1 04/17/19, 20:21 Completed build in 11m 28s on Wed, 17 Apr, 10:21 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33320

  5. Benni Mack uploaded patch set 3 04/26/19, 20:17

  6. TYPO3com voted on patch set 3 V +1 04/26/19, 20:31 Completed build in 13m 02s on Fri, 26 Apr, 10:31 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33512

  7. Susi Moog commented on patch set 3 04/27/19, 10:11

    ExtensionManagementUtility.php:818

    should the path always or never have a trailing slash? or do we allow inconsistent paths if configured that way?

    ExtensionManagementUtility.php:821

    trim in line 820 and avoid duplication?
  8. Benni Mack commented on patch set 3 05/06/19, 10:28

    ExtensionManagementUtility.php:818 Reply Unresolved

    people can configure it as they please. Same as with slug handling in FE. People _can_ add a page with ending "/" but it's never the default by Core.

    ExtensionManagementUtility.php:821 Reply Unresolved

    yup. will do.
  9. Benni Mack commented on patch set 4 05/13/19, 06:13

    Published edit on patch set 3.
  10. TYPO3com voted on patch set 4 V +1 05/13/19, 06:28 Completed build in 14m 36s on Mon, 13 May, 08:28 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33834

  11. Georg Ringer commented on patch set 4 05/21/19, 13:30

    Deprecation-82669-StreamlineBackendRoutePathInconsistencies.rst:18 Unresolved

    should also be mentioned that this is deprecated, not only discouraged
  12. Susi Moog voted on patch set 4 CR +1 06/21/19, 09:26

  13. Susi Moog voted on patch set 4 V +1 06/21/19, 09:31

  14. Daniel Gorges voted on patch set 4 V +1 CR +1 06/26/19, 04:16

  15. Benni Mack voted on patch set 4 V +2 CR +2 06/26/19, 04:32

  16. Benni Mack merged patch set 5 06/26/19, 04:32