Review main Merged

60435[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper

Benni Mack CR +2 V +2 Easy +1 −2 updated 04/10/19, 11:54

Commit message

Although the documentation and the internal
code allows File and FileReference, the functionality
requires a FileReference.

FileInterface is more appropriate and $cObj->imageLinkWrap()
can deal with File and FileReference.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jörg Bösche +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 04/10/19, 03:15

  2. TYPO3com voted on patch set 1 V +1 04/10/19, 03:26 Completed build in 10m 29s on Wed, 10 Apr, 05:26 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33149

  3. Steffen Frese voted on patch set 1 V +1 CR +1 04/10/19, 07:00

  4. Steffen Frese commented on patch set 1 04/10/19, 07:01

    > Patch Set 1: Verified+1 Code-Review+1 tested on master
  5. Jörg Bösche commented on patch set 1 V +1 CR +1 04/10/19, 08:18

    tested on dev-master (v10)
  6. Oliver Klee voted on patch set 1 CR +1 04/10/19, 08:45

  7. Georg Ringer voted on patch set 1 V +2 CR +2 04/10/19, 11:54

  8. Georg Ringer merged patch set 2 04/10/19, 11:54