Review main Merged

60436[BUGFIX] Do not use LSB in <f:form.select>

Benni Mack CR +2 V +2 Easy +5 −4 updated 04/11/19, 23:37

Commit message

<f:form.select.option> uses the FQDN::class
syntax, so late static binding (LSB) is leading
to side effects when extending <f:form.select>.

Using the self::class syntax in <f:form.select>
solves the issue.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Benni Mack uploaded patch set 1 04/10/19, 04:22

  2. TYPO3com voted on patch set 1 V -1 04/10/19, 04:42 Completed build in 15m 50s on Wed, 10 Apr, 06:42 AM Test Summary: 2 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33150

  3. Oliver Klee commented on patch set 1 04/10/19, 08:46

    SelectViewHelper.php:151

    Wouldn't self:: work as well (and be shorter)?
  4. Jörg Bösche commented on patch set 1 04/10/19, 10:05

    > (1 comment) I think it is easier to find "usage" with PhpStorm or analysis tools, if the FQDN::class is implemented.
  5. Oliver Klee commented on patch set 1 04/10/19, 10:48

    > I think it is easier to find "usage" with PhpStorm or analysis tools, if the FQDN::class is implemented. I've just checked with PhpStorm: It finds the class usage just fine when self:: is used.
  6. Benni Mack commented on patch set 1 04/10/19, 13:28

    SelectViewHelper.php:151 Reply

    yeah - fine with me. IMHO the important part is that we document/comment that we do NOT want to use LSB here, so no "hey, lets run a automatic code checker and make our code 0.0001% faster" changes this again to static:: at some point.
  7. Benni Mack commented on patch set 2 04/10/19, 13:30

    Published edit on patch set 1.
  8. Benni Mack updated the commit message in patch set 3 04/10/19, 13:30

  9. Oliver Klee voted on patch set 3 CR +1 04/10/19, 13:36

  10. TYPO3com voted on patch set 2 V +1 04/10/19, 13:47 Completed build in 16m 43s on Wed, 10 Apr, 03:47 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33180

  11. TYPO3com voted on patch set 3 V +1 04/10/19, 13:48 Completed build in 17m 09s on Wed, 10 Apr, 03:48 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33181

  12. Tobi Kretschmann voted on patch set 3 CR +1 04/10/19, 13:54

  13. Steffen Frese voted on patch set 3 CR +1 04/11/19, 09:57

  14. Jörg Bösche voted on patch set 3 CR +1 04/11/19, 10:13

  15. Tobi Kretschmann voted on patch set 3 V +1 04/11/19, 13:41

  16. Jörg Bösche voted on patch set 3 V +1 04/11/19, 13:41

  17. Benni Mack voted on patch set 3 V +2 CR +2 04/11/19, 23:37

  18. Benni Mack merged patch set 4 04/11/19, 23:37