Review TYPO3_8-7 Abandoned

60441[BUGFIX] prevent module body from jumping out of screen on scheduler task selection

Tobi Kretschmann CR 0 V 0 Easy +3 −2 updated 10/25/19, 20:00

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1012

  1. Tobi Kretschmann uploaded patch set 1 04/10/19, 09:23

  2. Tobi Kretschmann updated the commit message in patch set 2 04/10/19, 09:24

  3. Tobi Kretschmann commented on patch set 2 04/10/19, 09:40

    Although I don't think this is the best way to fix this behavior, I couldn't figure out why this is happening only in V8.7
  4. TYPO3com voted on patch set 1 V +1 04/10/19, 09:47 Completed build in 24m 14s on Wed, 10 Apr, 11:47 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3462

  5. TYPO3com voted on patch set 2 V +1 04/10/19, 09:51 Completed build in 26m 38s on Wed, 10 Apr, 11:51 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3463

  6. Steffen Frese voted on patch set 2 V +1 CR +1 04/10/19, 12:30

  7. Oliver Klee commented on patch set 2 04/10/19, 12:36

    Are master and 9.5 not affected?
  8. Tobi Kretschmann commented on patch set 2 04/11/19, 07:01

    Reply

    no, it's only in V8.
  9. Jörg Bösche voted on patch set 2 V +1 CR +1 04/11/19, 10:05

  10. Oliver Klee wrote 04/11/19, 10:36

    Removed reviewer Oliver Klee.
  11. Susi Moog commented on patch set 2 CR -1 04/14/19, 14:30

    changing the positioning of the module body in general in v8 seems risky to me and I'd say the issue is non-critical - I would not fix this in v8 anymore. @Benni: What do you say?
  12. Susi Moog abandoned the change 10/25/19, 20:00

    no feedback, not critical.