Review 9.5 Merged

60444[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper

Georg Ringer CR +2 V +2 Easy +1 −2 updated 04/10/19, 12:57

Commit message

Although the documentation and the internal
code allows File and FileReference, the functionality
requires a FileReference.

FileInterface is more appropriate and $cObj->imageLinkWrap()
can deal with File and FileReference.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 04/10/19, 11:54

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/10/19, 12:09 Completed build in 14m 30s on Wed, 10 Apr, 02:09 PM Test Summary: 49974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-482

  3. Georg Ringer voted on patch set 1 V +2 CR +2 04/10/19, 12:57

  4. Georg Ringer merged patch set 2 04/10/19, 12:57