Review 9.5 Merged

60448[BUGFIX] Add table name as prefix for language DB selection

Georg Ringer CR +2 V +2 Easy +1 −1 updated 04/11/19, 06:21

Commit message

When building JOINs with TypoScript of tt_content or
any localized table, using "LEFTJOIN tt_content table2"
the language restriction check is not using a prefix
for the "l10n_parent" field.

The "sys_language_uid" field already has the same prefix
built in the same method.

This error existed in v8 already, but in TYPO3 v9, the
"includeRecordsWithoutDefaultTranslation" option is enabled
by default (via LanguageAspect), therefore it's more
prominent.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 04/10/19, 19:04

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/10/19, 19:19 Completed build in 14m 51s on Wed, 10 Apr, 09:19 PM Test Summary: 49974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-484

  3. Benni Mack voted on patch set 1 V +2 CR +2 04/11/19, 06:21

  4. Benni Mack merged patch set 2 04/11/19, 06:21