Review 9.5 Merged

60452[BUGFIX] Do not use LSB in <f:form.select>

Benni Mack CR +2 V +2 Easy +5 −4 updated 04/11/19, 23:54

Commit message

<f:form.select.option> uses the FQDN::class
syntax, so late static binding (LSB) is leading
to side effects when extending <f:form.select>.

Using the self::class syntax in <f:form.select>
solves the issue.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 04/11/19, 23:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/11/19, 23:54 Completed build in 16m 32s on Fri, 12 Apr, 01:54 AM Test Summary: 49974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-489

  3. Benni Mack voted on patch set 1 V +2 CR +2 04/11/19, 23:54

  4. Benni Mack merged patch set 2 04/11/19, 23:54