Review main Merged Breaking

60453[!!!][TASK] Remove legacy "pageNotFound_handling" options

Benni Mack CR +2 V +2 Expert +299 −852 updated 01/24/20, 09:15

Commit message

With the introduction of site handling, the old "pageNotFound_handling"
mechanisms can be removed. If a site configuration hasn't configured
a error handler, a 404/403/500 response with the default error
renderer is now returned. Making PageNotFoundExceptions rendering
the frontend very seldom.

The following options are removed:
- $TYPO3_CONF_VARS[FE][pageNotFound_handling]
- $TYPO3_CONF_VARS[FE][pageNotFound_handling_statheader]
- $TYPO3_CONF_VARS[FE][pageNotFound_handling_accessdeniedheader]
- $TYPO3_CONF_VARS[FE][pageUnavailable_handling]
- $TYPO3_CONF_VARS[FE][pageUnavailable_handling_statheader]

Tests have been adopted to check against status code / message
rather than on the exceptions (not) thrown (anymore).

In addition, a JsonResponse is now returned if JSON
was requested, instead of the regular HTML content.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2640

Show 815 earlier messages
  1. Benni Mack uploaded patch set 1 04/12/19, 00:40

  2. TYPO3com voted on patch set 1 V -1 04/12/19, 00:56 Completed build in 16m 18s on Fri, 12 Apr, 02:56 AM Test Summary: 332 of 47664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33200

  3. Benni Mack uploaded patch set 2 04/12/19, 21:07

  4. TYPO3com voted on patch set 2 V -1 04/12/19, 21:20 Completed build in 13m 01s on Fri, 12 Apr, 11:20 PM Test Summary: 272 of 47676 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33225

  5. Benni Mack uploaded patch set 3 05/15/19, 20:32

  6. TYPO3com voted on patch set 3 V -1 05/15/19, 20:45 Completed build in 13m 26s on Wed, 15 May, 10:45 PM Test Summary: 99 of 46776 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33889

  7. Benni Mack uploaded patch set 4 05/15/19, 21:16

  8. TYPO3com voted on patch set 4 V -1 05/15/19, 21:29 Completed build in 13m 00s on Wed, 15 May, 11:29 PM Test Summary: 96 of 46776 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33890

  9. Benni Mack uploaded patch set 5 05/16/19, 10:15

  10. TYPO3com voted on patch set 5 V -1 05/16/19, 10:28 Completed build in 12m 50s on Thu, 16 May, 12:28 PM Test Summary: 196 of 46784 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33895

  11. Benni Mack uploaded patch set 6 05/16/19, 19:41

  12. TYPO3com voted on patch set 6 V -1 05/16/19, 19:53 Completed build in 11m 39s on Thu, 16 May, 09:53 PM Test Summary: 61 of 46757 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33901

  13. Benni Mack uploaded patch set 7 05/16/19, 20:20

  14. TYPO3com voted on patch set 7 V -1 05/16/19, 20:32 Completed build in 11m 48s on Thu, 16 May, 10:32 PM Test Summary: 9 of 46712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33902

  15. Benni Mack uploaded patch set 8 05/16/19, 20:39

  1. TYPO3com voted on patch set 8 V +1 05/16/19, 20:51 Completed build in 11m 51s on Thu, 16 May, 10:51 PM Test Summary: 46371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33903

  2. Benni Mack uploaded patch set 9 05/16/19, 21:12

  3. TYPO3com voted on patch set 9 V +1 05/16/19, 21:24 Completed build in 12m 15s on Thu, 16 May, 11:24 PM Test Summary: 46373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33904

  4. Wouter Wolters voted on patch set 9 CR +1 05/17/19, 07:20

  5. Andreas Kienast commented on patch set 9 CR -1 05/17/19, 08:30

    on it
  6. Andreas Kienast uploaded patch set 10 05/17/19, 08:43

  7. Andreas Kienast voted on patch set 10 V +1 CR +1 05/17/19, 08:46

  8. TYPO3com voted on patch set 10 V +1 05/17/19, 08:56 Completed build in 12m 43s on Fri, 17 May, 10:56 AM Test Summary: 46373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33906

  9. Susi Moog commented on patch set 10 CR -1 05/17/19, 11:33

    ErrorController.php:154 Unresolved

    either set the statusCode here or in the single response lines, setting it twice in the json case is unnecessary.

    ErrorControllerTest.php:30 Unresolved

    in comparison to the test cases before, test coverage has gone down - at least the json response vs. html response can be tested here.
  10. Benni Mack uploaded patch set 11 05/19/19, 16:45

  11. TYPO3com voted on patch set 11 V -1 05/19/19, 16:46 Completed build in 16s on Sun, 19 May, 06:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33926

  12. Benni Mack uploaded patch set 12 05/19/19, 16:47

  13. TYPO3com commented on patch set 12 05/19/19, 16:47 Completed build in 16s on Sun, 19 May, 06:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33927

  14. Benni Mack updated the commit message in patch set 13 05/19/19, 16:47

  15. TYPO3com voted on patch set 13 V -1 05/19/19, 16:48 Completed build in 14s on Sun, 19 May, 06:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33928

  16. Benni Mack uploaded patch set 14 05/19/19, 16:49

  17. TYPO3com voted on patch set 14 V +1 05/19/19, 17:03 Completed build in 13m 56s on Sun, 19 May, 07:03 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33929

  18. Georg Ringer voted on patch set 14 V +1 CR +1 05/20/19, 10:55

  19. Helmut Hummel commented on patch set 14 05/20/19, 11:52

    ErrorController.php:51

    Just a minor thing from experience. Depending on when the unavailableAction is triggered, it could be, that site is not populated in the request object yet, leading to the default error to be triggered. In 9.5 I worked around that by additionally configuring pageUnavailable_handling, manually resolving the site there and then calling the ErrorController. With removing the global unavailable handling this is not possible any more. So my suggestion would be to extend getErrorHandlerFromSite to manually resolve the site in case it has not been populated in request
  20. Benni Mack commented on patch set 14 05/20/19, 13:34

    ErrorController.php:51 Reply

    we could extend this at a later step, to expose this method as API, what do you think?
  21. Anja Leichsenring voted on patch set 14 V +1 CR +1 05/21/19, 09:35

  22. Benni Mack voted on patch set 14 V +2 CR +2 05/21/19, 10:45

  23. Benni Mack merged patch set 15 05/21/19, 10:45

  24. Oliver Hader commented on patch set 15 01/22/20, 17:25

    Is there a way to still enforce having exception being thrown (individually)?
  25. Benni Mack commented on patch set 15 01/24/20, 09:15

    > Patch Set 15: > > Is there a way to still enforce having exception being thrown (individually)? For pageUnavailableAction (see EXT:frontend -> ErrorController) this is possible by setting the right devIpMask. For others I recommend creating a site config error handler that throws an exception :)