Review main Merged

60454[BUGFIX] Fluid viewhelper f:format.date() uses timestamp from context aspect

Jörg Bösche CR +2 V +2 Easy +5 −1 updated 04/27/19, 08:36

Commit message

Use timestamp from context runtime instead of use time() in
viewhelper calls to prevent different dates in rendering process.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1725

  1. Jörg Bösche uploaded patch set 1 04/12/19, 11:29

  2. Jörg Bösche rebased onto patch set 2 04/12/19, 11:31

  3. Jörg Bösche uploaded patch set 3 04/12/19, 11:33

  4. Jörg Bösche wrote 04/12/19, 11:45

    Removed reviewer Benni Mack.
  5. TYPO3com voted on patch set 1 V +1 04/12/19, 11:46 Completed build in 17m 45s on Fri, 12 Apr, 01:46 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33210

  6. TYPO3com voted on patch set 2 V +1 04/12/19, 11:49 Completed build in 18m 05s on Fri, 12 Apr, 01:49 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33211

  7. Tobi Kretschmann voted on patch set 3 CR +1 04/12/19, 11:49

  8. TYPO3com voted on patch set 3 V +1 04/12/19, 11:54 Completed build in 17m 51s on Fri, 12 Apr, 01:54 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33212

  9. Steffen Frese commented on patch set 4 04/12/19, 12:31

    Published edit on patch set 3.
  10. Steffen Frese updated the commit message in patch set 5 04/12/19, 12:32

  11. Steffen Frese commented on patch set 6 04/12/19, 12:34

    Published edit on patch set 5.
  12. Tobi Kretschmann voted on patch set 6 CR +1 04/12/19, 12:34

  13. Steffen Frese uploaded patch set 7 04/12/19, 12:43

  14. TYPO3com voted on patch set 4 V +1 04/12/19, 12:45 Completed build in 13m 15s on Fri, 12 Apr, 02:45 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33213

  15. Jörg Bösche voted on patch set 7 V +1 CR +1 04/12/19, 12:46

  16. TYPO3com voted on patch set 6 V +1 04/12/19, 12:52 Completed build in 13m 38s on Fri, 12 Apr, 02:52 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33215

  17. TYPO3com voted on patch set 5 V +1 04/12/19, 12:53 Completed build in 21m 15s on Fri, 12 Apr, 02:53 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33214

  18. TYPO3com voted on patch set 7 V +1 04/12/19, 13:00 Completed build in 16m 57s on Fri, 12 Apr, 03:00 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33216

  19. Benni Mack commented on patch set 7 CR -1 04/13/19, 01:53

    this ain't a feature, it's a bugfix. Please remove the RST (sorry for the additional work)
  20. Andreas Kienast uploaded patch set 8 04/13/19, 13:52

  21. TYPO3com voted on patch set 8 V +1 04/13/19, 14:06 Completed build in 14m 17s on Sat, 13 Apr, 04:06 PM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33235

  22. Tobi Kretschmann voted on patch set 8 CR +1 04/13/19, 15:50

  23. Jörg Bösche voted on patch set 8 V +1 CR +1 04/15/19, 07:07

  24. Daniel Goerz voted on patch set 8 V +2 CR +2 04/27/19, 08:36

  25. Daniel Goerz merged patch set 9 04/27/19, 08:36