Review main Merged

60463[BUGFIX] Do not apply stdWrap on USER_INT

Benni Mack CR +2 V +2 Easy +4 −3 updated 05/07/19, 06:54

Commit message

When converting a USER to USER_INT ContentObject
the stdWrap is now executed only once instead
of multiple times.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1517

  1. Benni Mack uploaded patch set 1 04/13/19, 06:16

  2. TYPO3com voted on patch set 1 V +1 04/13/19, 06:26 Completed build in 09m 26s on Sat, 13 Apr, 08:26 AM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33232

  3. Andreas Kienast voted on patch set 1 CR +1 04/13/19, 13:59

  4. Oliver Klee commented on patch set 1 04/15/19, 15:13

    No 9.5?
  5. Benni Mack commented on patch set 1 04/17/19, 09:08

    Reply

    I'm not 100% sure if people already rely on this functionality, so I can't really get a feeling if that would break something badly for TER extensions for instance. However, it is a bugfix still - so we could add an important RST but still target for master only. what do you think?
  6. Oliver Klee commented on patch set 1 04/17/19, 09:17

    I'd prefer to have this in 9.5 as well as this a bug fix. And if this goes into master only, I agree that we should have an importand RST.
  7. Oliver Klee commented on patch set 1 04/17/19, 09:24

    (And I estimate it highly unlikely that an extension would rely on stdWrap being applied multiple times.)
  8. Benni Mack updated the commit message in patch set 2 04/17/19, 10:12

  9. Benni Mack commented on patch set 2 04/17/19, 10:12

    agreed!
  10. TYPO3com voted on patch set 2 V +1 04/17/19, 10:27 Completed build in 14m 42s on Wed, 17 Apr, 12:27 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33300

  11. Oliver Klee voted on patch set 2 CR +1 04/17/19, 10:47

  12. Andreas Kienast voted on patch set 2 CR +1 04/17/19, 11:04

  13. Josef Glatz commented on patch set 2 04/18/19, 14:52

    What speaks against a RsT if the bugfix get's merged into both branches? The fix keeps the same. As an integrator I would definitely assume that such a bugfix will be announced with at least an "!!!" in the changeLog.
  14. Georg Ringer commented on patch set 2 04/19/19, 18:42

    nobody reads changelogs or rst files until it is too late. I am against 9.5 but won't stop any backport. there will be a 10 and a 11 and not every bugfix needs to be backported
  15. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/23/19, 18:42

  16. Georg Ringer voted on patch set 2 V +2 CR +2 05/07/19, 06:42

  17. Benni Mack merged patch set 3 05/07/19, 06:54