60464[BUGFIX] Apply quality settings for images
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 810
-
Benni Mack uploaded patch set 1 04/13/19, 06:25
-
TYPO3com voted on patch set 1 V +1 04/13/19, 06:36 Completed build in 10m 18s on Sat, 13 Apr, 08:36 AM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33233
-
Guido Schmechel commented on patch set 1 V +1 CR +1 04/13/19, 20:32
Verified with master and InstallTool test. Btw: Scaling images "gif to jpg" doesn't use the quality setting, too, Should we change this with this patch or create a new issue and patch? typo3/sysext/install/Classes/Controller/EnvironmentController.php -> line 528 -
Benni Mack commented on patch set 1 04/14/19, 09:17
feel free to improve! -
Guido Schmechel uploaded patch set 2 04/14/19, 11:16
-
TYPO3com voted on patch set 2 V +1 04/14/19, 11:26 Completed build in 10m 30s on Sun, 14 Apr, 01:26 PM Test Summary: 47412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33250
-
Guido Schmechel commented on patch set 2 04/14/19, 11:27
Hopefully I understand you correct ;-) -
Benni Mack commented on patch set 2 V +1 CR +1 04/15/19, 12:27
looks good. -
Georg Ringer voted on patch set 2 V +2 CR +2 04/15/19, 13:09
-
Georg Ringer merged patch set 3 04/15/19, 13:09