Review main Merged

60466[BUGFIX] Ensure correct value for JsonResponse in InstallerController

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 05/10/19, 15:04

Commit message

Set the correct status value for the JsonResponse returned in case no
database is selected.
Additionally, a typo in the key `success` itself is fixed.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Guido Schmechel uploaded patch set 1 04/13/19, 18:39

  2. Andreas Kienast updated the commit message in patch set 2 04/13/19, 18:42

  3. Andreas Kienast voted on patch set 2 CR +1 04/13/19, 18:43

  4. TYPO3com voted on patch set 1 V +1 04/13/19, 18:53 Completed build in 14m 01s on Sat, 13 Apr, 08:53 PM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33241

  5. TYPO3com voted on patch set 2 V +1 04/13/19, 18:57 Completed build in 14m 53s on Sat, 13 Apr, 08:57 PM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33242

  6. Andreas Kienast voted on patch set 2 V +1 05/10/19, 15:02

  7. Frank Nägler voted on patch set 2 V +2 CR +2 05/10/19, 15:04

  8. Frank Nägler merged patch set 3 05/10/19, 15:04