Review main Merged

60468[BUGFIX] Properly handle deleted placeholders in TCA group and select

Robert Vock CR +2 V +2 Normal +155 −0 updated 11/08/21, 17:42

Commit message

The TCA types "group" and "select" are both using the
relation handler to resolve items from foreign tables.
Previously, delete placeholders were still fetched
in a workspace. This is now fixed by properly handling
the delete placeholders before fetching the items.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2434

Show 79 earlier messages
  1. Robert Vock uploaded patch set 1 04/14/19, 12:05

  2. TYPO3com voted on patch set 1 V -1 04/14/19, 12:20 Completed build in 14m 46s on Sun, 14 Apr, 02:20 PM Test Summary: 444 of 47811 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33251

  3. Robert Vock uploaded patch set 2 04/15/19, 08:16

  4. TYPO3com voted on patch set 2 V +1 04/15/19, 08:34 Completed build in 17m 38s on Mon, 15 Apr, 10:34 AM Test Summary: 47463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33270

  5. Oliver Klee commented on patch set 2 04/15/19, 09:47

    Shouldn't 9.5 be here as well?
  6. Robert Vock commented on patch set 2 04/15/19, 09:56

    > Patch Set 2: > > (1 comment) You're correct. 9.5 is missing. Should I remove the 8.7 as well? I think this patch would improve 8.7, but 8.7 should only receive "security and critical fixes". Depends on wether this is a critical fix or not
  7. Oliver Klee commented on patch set 2 04/15/19, 10:27

    Susi says "no 8.7 for this" on Slack.
  8. Oliver Klee updated the commit message in patch set 3 04/15/19, 10:27

  9. Oliver Hader commented on patch set 3 04/15/19, 10:38

    RelationHandler.php:1565

    +1 delete placeholder is in according workspace, "eq" is correct here
  1. TYPO3com voted on patch set 3 V +1 04/15/19, 10:41 Completed build in 13m 56s on Mon, 15 Apr, 12:41 PM Test Summary: 47463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33273

  2. Benni Mack wrote 09/27/19, 08:59

    Topic set to workspaces
  3. Benni Mack commented on patch set 3 09/27/19, 09:01

    RelationHandler.php:1565 Reply Unresolved

    "funny" - looks like this is an error from the Doctrine DBAL migration.
  4. Benni Mack uploaded patch set 4 09/27/19, 10:09

  5. Benni Mack uploaded patch set 5 09/27/19, 10:13

  6. Benni Mack uploaded patch set 6 09/27/19, 10:16

  7. TYPO3com voted on patch set 4 V -1 09/27/19, 10:21 Completed build in 11m 30s on Fri, 27 Sep, 10:21 AM Test Summary: 46985 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36876

  8. TYPO3com voted on patch set 5 V +1 09/27/19, 10:28 Completed build in 13m 01s on Fri, 27 Sep, 10:28 AM Test Summary: 47722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36877

  9. TYPO3com voted on patch set 6 V -1 09/27/19, 10:33 Completed build in 13m 29s on Fri, 27 Sep, 10:33 AM Test Summary: 28 of 48081 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36878

  10. Benni Mack uploaded patch set 7 09/27/19, 12:46

  11. Benni Mack voted on patch set 7 V +1 CR +1 09/27/19, 12:47

  12. TYPO3com voted on patch set 7 V +1 09/27/19, 12:56 Completed build in 10m 09s on Fri, 27 Sep, 12:56 PM Test Summary: 47722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36892

  13. Riccardo De Contardi commented on patch set 7 V -1 11/06/19, 21:54

    Tried the following test on latest master: Before the patch is applied: 1) sysfolder > create file collection "test 1"; type: static selection of files; add some files 2) sysfolder > create file collection "test 2"; type: static selection of files; add some other files 3) Create a filelist element on a page and add the two collections 4) Change to a workspace and delete sys_file_collection "test1". - The popup says: Are you sure you want to delete this record? "Test 1" [sys_file_collection:7] (There are 3 reference(s) to this record!) 5) Edit again the filelist element Result: the two collections are present, both on the workspace and LIVE. After the patch is applied 6) Repeat steps 1-4 (I recreated all the records from scratch) 7) Go to the page that contains the filelist element Result: you see TWO filelist elements, both with only the file collection "Test 2" content element! Please note that the new filelist element is present only in the workspace.
  14. Benni Mack uploaded patch set 8 04/30/20, 07:09

  15. TYPO3com voted on patch set 8 V +1 04/30/20, 07:24 Completed build in 14m 57s on Thu, 30 Apr, 07:24 AM Test Summary: 73669 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3114

  16. Benni Mack updated the commit message in patch set 9 05/25/20, 18:48

  17. TYPO3com voted on patch set 9 V +1 08/10/20, 09:00 Completed build in 11m 44s on Mon, 10 Aug, 09:00 AM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4535

  18. Oliver Hader commented on patch set 9 CR -1 11/05/21, 11:35

    AbstractItemProvider.php:1273

    Should be called after `RelationHandler::start` since it processes `RelationHandler::$tableArray`, which is not initialized at that point.
  19. Oli Bartsch uploaded patch set 10 11/08/21, 16:52

  20. Oli Bartsch commented on patch set 10 11/08/21, 16:52

    AbstractItemProvider.php:1273 Reply

    Done
  21. core-ci voted on patch set 10 V +1 11/08/21, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19032

  22. Oli Bartsch voted on patch set 10 V +1 CR +1 11/08/21, 17:07

  23. Benni Mack voted on patch set 10 V +1 CR +1 11/08/21, 17:34

  24. Oli Bartsch voted on patch set 10 V +2 CR +2 11/08/21, 17:42

  25. Oli Bartsch merged patch set 11 11/08/21, 17:42