60477[BUGFIX] Add VendorName to Fluid Ajax WidgetContext
Commit message
Review
-
Code review CR +2 Done
- Alexander Schnitzler +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Jörg Bösche +1
- Felix P. +1
-
Verified V +2 Done
- Alexander Schnitzler +2
- Markus Klösges +1
- Tobi Kretschmann +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2428
Show 23 earlier messages
-
Stefan Froemken uploaded patch set 1 04/15/19, 11:58
-
TYPO3com voted on patch set 1 V -1 04/15/19, 12:12 Completed build in 13m 24s on Mon, 15 Apr, 02:12 PM Test Summary: 4 of 50596 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-509
-
Georg Ringer commented on patch set 1 CR -1 04/16/19, 02:05
please add master as well in relUnresolved
please add master as well
-
Stefan Froemken commented on patch set 1 04/16/19, 05:11
> please add master as well in rel Nope. Alexander Schnitzler has removed VendorName in Version 10. So, if I add master we have 83 failing UnitTests. -
Georg Ringer voted on patch set 1 V +1 CR +1 04/24/19, 11:27
-
Stefan Froemken uploaded patch set 2 04/24/19, 11:43
-
TYPO3com voted on patch set 2 V +1 04/24/19, 11:55 Completed build in 12m 03s on Wed, 24 Apr, 01:55 PM Test Summary: 50128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-548
-
Andreas Kienast voted on patch set 2 CR +1 08/05/19, 13:14
-
Pascal Querner commented on patch set 2 V -1 CR -1 08/08/19, 16:20
I tried your Bugfix, but it doesnt work. vendorName is still NULL in context. I found out that the wrong variable is set in the setter below.WidgetContext.php:180UnresolvedThis should set $parentVendorName instead. -
Pascal Querner commented on patch set 2 08/08/19, 16:23
> Patch Set 2: Verified-1 Code-Review-1 > > (1 comment) > > I tried your Bugfix, but it doesnt work. vendorName is still NULL in context. I found out that the wrong variable is set in the setter below. I can confirm it works if you fix the setter method. :) -
Pascal Querner commented on patch set 2 08/09/19, 10:13
> Patch Set 2: > > > Patch Set 2: Verified-1 Code-Review-1 > > > > (1 comment) > > > > I tried your Bugfix, but it doesnt work. vendorName is still NULL in context. I found out that the wrong variable is set in the setter below. > > I can confirm it works if you fix the setter method. :) Only tested against 9.5.8. Does not work on master (0fc8cc94d2c1334137455865a1d141d84011bf36) because of Call to undefined method TYPO3\CMS\Extbase\Mvc\Web\Request::getControllerVendorName() in /var/www/html/typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php line 128 { $this->widgetContext->setWidgetConfiguration($this->getWidgetConfiguration()); $this->initializeWidgetIdentifier(); $this->widgetContext->setControllerObjectName(get_class($this->controller)); $vendorName = $this->renderingContext->getControllerContext()->getRequest()->getControllerVendorName(); $extensionName = $this->renderingContext->getControllerContext()->getRequest()->getControllerExtensionName(); $pluginName = $this->renderingContext->getControllerContext()->getRequest()->getPluginName(); $this->widgetContext->setParentVendorName($vendorName); $this->widgetContext->setParentExtensionName($extensionName); -
Andreas Kienast commented on patch set 3 08/09/19, 12:02
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 08/09/19, 12:14 Completed build in 11m 55s on Fri, 9 Aug, 12:14 PM Test Summary: 84 of 51001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1000
-
Pascal Querner voted on patch set 3 V +1 CR +1 08/09/19, 12:44
-
Andreas Kienast rebased onto patch set 4 08/12/19, 18:26
-
TYPO3com voted on patch set 4 V +1 08/12/19, 18:38 Completed build in 12m 00s on Mon, 12 Aug, 06:38 PM Test Summary: 50533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1005
-
Markus Klösges commented on patch set 4 V +1 09/13/19, 10:58
Error confirmed in 9.5.9; applying the patch through composer fixed the error -
Tobi Kretschmann voted on patch set 4 CR +1 10/09/19, 13:29
-
Jörg Bösche voted on patch set 4 CR +1 10/10/19, 06:25
-
Sascha Rademacher voted on patch set 4 CR +1 10/10/19, 06:55
-
Felix P. voted on patch set 4 CR +1 10/10/19, 08:37
-
Tobi Kretschmann voted on patch set 4 V +1 10/29/19, 14:05
-
Oli Bartsch commented on patch set 4 10/29/19, 14:17
WidgetContext.php:178UnresolvedCould we add a type hint here?WidgetContext.php:188UnresolvedCould we add the return type here? -
Alexander Schnitzler commented on patch set 4 CR -1 10/31/19, 10:08
Let me check if this patch qualifies as a priority bugfix (for 8.7). -
Alexander Schnitzler wrote 12/13/19, 16:54
Removed Code-Review-1 by Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> -
Alexander Schnitzler commented on patch set 4 12/13/19, 16:59
I will take care of this patch this weekend. -
Alexander Schnitzler voted on patch set 4 V +2 CR +2 12/14/19, 13:21
-
Alexander Schnitzler merged patch set 5 12/14/19, 13:22