60487[BUGFIX] Respect offset of original query in PaginateController
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Richard Haeser +1
-
Verified V +2 Done
- Daniel Goerz +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1721
-
Chris Müller uploaded patch set 1 04/16/19, 13:52
-
TYPO3com voted on patch set 1 V -1 04/16/19, 14:06 Completed build in 13m 27s on Tue, 16 Apr, 04:06 PM Test Summary: 18 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33293
-
TYPO3com voted on patch set 1 V +1 04/16/19, 15:00 Completed build in 1h 21m 27s on Tue, 16 Apr, 05:00 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33293
-
Frank Nägler voted on patch set 1 CR +1 08/09/19, 13:44
-
Josef Glatz voted on patch set 1 CR +1 08/10/19, 05:39
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 08/24/19, 15:14
-
Daniel Goerz commented on patch set 1 CR -1 08/29/19, 09:10
-
Daniel Goerz uploaded patch set 2 08/29/19, 09:12
-
Daniel Goerz voted on patch set 2 V +1 CR +1 08/29/19, 09:13
-
TYPO3com voted on patch set 2 V +1 08/29/19, 09:24 Completed build in 11m 16s on Thu, 29 Aug, 09:24 AM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35912
-
Andreas Kienast voted on patch set 2 CR +1 08/30/19, 11:24
-
Chris Müller voted on patch set 2 CR +1 08/31/19, 18:27
-
Oli Bartsch voted on patch set 2 CR +1 09/01/19, 20:14
-
Richard Haeser voted on patch set 2 CR +1 09/02/19, 06:25
-
Richard Haeser commented on patch set 2 CR 0 09/02/19, 06:30
Thanks for the patch. One minor thing: the commit message is only a description of the problem and not a summary of what this patch does. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html for more information about the guides of the commit message. I will change the commit message but please let me know if the new commit message is still accurate for you. -
Richard Haeser updated the commit message in patch set 3 09/02/19, 06:34
-
TYPO3com voted on patch set 3 V +1 09/02/19, 06:44 Completed build in 09m 43s on Mon, 2 Sep, 06:44 AM Test Summary: 47248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35978
-
Richard Haeser voted on patch set 3 V +1 CR +1 09/02/19, 06:47
-
Oli Bartsch voted on patch set 3 CR +1 09/02/19, 06:50
-
Daniel Goerz voted on patch set 3 V +2 CR +2 09/02/19, 07:12
-
Daniel Goerz merged patch set 4 09/02/19, 07:12
PaginateController.php:98Unresolved