Review main Merged

60488[TASK] Improve click behavior of the pagetree

Alexander Stehlik CR +2 V +2 Easy +11 −2 updated 06/06/19, 19:42

Commit message

Initialize the d3-drag clickDistance setting to prevent clicks
where the mouse slightly moves from being detected as drag
attempts.

See also:
https://github.com/d3/d3-drag#drag_clickDistance

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Daniel Goerz +1
    • Paweł Rogowicz +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Jonas Eberle +1
    • Paweł Rogowicz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2226

Show 1 earlier messages
  1. Alexander Stehlik uploaded patch set 1 04/16/19, 17:37

  1. Alexander Stehlik updated the commit message in patch set 2 04/16/19, 17:38

  2. TYPO3com voted on patch set 1 V -1 04/16/19, 17:52 Completed build in 15m 13s on Tue, 16 Apr, 07:52 PM Test Summary: 1 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33294

  3. TYPO3com voted on patch set 2 V +1 04/16/19, 17:53 Completed build in 15m 20s on Tue, 16 Apr, 07:53 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33295

  4. Alexander Stehlik updated the commit message in patch set 3 04/23/19, 08:39

  5. TYPO3com voted on patch set 3 V +1 04/23/19, 08:54 Completed build in 14m 50s on Tue, 23 Apr, 10:54 AM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33374

  6. Sven Juergens voted on patch set 3 CR +1 05/28/19, 14:35

  7. Sven Juergens voted on patch set 3 V +1 05/28/19, 15:00

  8. Tobi Kretschmann voted on patch set 3 CR +1 05/28/19, 19:39

  9. Tymoteusz Motylewski commented on patch set 3 CR +1 05/28/19, 20:44

    Thanks for the patch. Looks good, it just need to be tested carefully. When testing please specify which browser did you cover.
  10. Jonas Eberle commented on patch set 3 V +1 06/04/19, 12:45

    I am able to reproduce the problem with FF 67 and Chromium 74 (click is not triggered when moving slightly). The patch works for extremely slight movements but is nearly not noticable. I found a value of clickDistance(5) even nicer to work with. Dragging is triggered > ~10px.
  11. Daniel Goerz voted on patch set 3 CR +1 06/05/19, 19:06

  12. Tymoteusz Motylewski commented on patch set 3 CR 0 06/05/19, 19:15

    Plz dont merge, will give it a spinn tomorrow
  13. Paweł Rogowicz commented on patch set 3 CR -1 06/06/19, 07:07

    There is one place to change it too in PageTreeDragDrop.js:504, function name 'isDragNodeDistanceMore'
  14. Daniel Goerz voted on patch set 3 CR 0 06/06/19, 07:17

  15. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 06/06/19, 12:59

  16. Tymoteusz Motylewski commented on patch set 4 06/06/19, 12:59

    Published edit on patch set 3.
  17. Tymoteusz Motylewski voted on patch set 4 V +1 CR +1 06/06/19, 12:59

  18. Tymoteusz Motylewski commented on patch set 4 06/06/19, 13:02

    The drag starts when item is moved >10px, so it should be safe to change the clickDistance to 5px
  19. Daniel Goerz voted on patch set 4 CR +1 06/06/19, 13:03

  20. Paweł Rogowicz commented on patch set 4 V +1 CR +1 06/06/19, 13:07

    > Patch Set 3: -Code-Review I misunderstand this clickDistance, I thought it was for minimum drag distance, not for click distance. I checked it and verified and everything is work
  21. TYPO3com voted on patch set 4 V +1 06/06/19, 13:12 Completed build in 12m 53s on Thu, 6 Jun, 03:12 PM Test Summary: 46494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34226

  22. Jonas Eberle voted on patch set 4 V +1 06/06/19, 13:22

  23. Jonas Eberle commented on patch set 4 06/06/19, 13:27

    Oh, when the drugs kick in and clicking without moving gets hard... TYPO3: now catering for drunk people, too! :D (I love it)
  24. Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 06/06/19, 19:41

  25. Tymoteusz Motylewski merged patch set 5 06/06/19, 19:42