60490[BUGFIX] Make CodeMirror search persistent
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Sven Juergens +1
-
Verified V +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Sven Juergens +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Andreas Kienast uploaded patch set 1 04/17/19, 09:25
-
TYPO3com voted on patch set 1 V +1 04/17/19, 09:39 Completed build in 13m 36s on Wed, 17 Apr, 11:39 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33299
-
Sven Juergens commented on patch set 1 04/17/19, 10:50
-
Andreas Kienast commented on patch set 1 04/17/19, 11:03
T3editor.ts:65ReplyI could do that, but I need to verify this with a macOS which I don't have at hand right now. I will try to check this on a macBook in the next days. -
Sven Juergens commented on patch set 1 04/17/19, 11:41
> Patch Set 1: > > (1 comment)T3editor.ts:65Reply UnresolvedAll right, if it helps, I have a screencast attached to the ticket with ctrl + f and cmd + f on a Mac -
Andreas Kienast uploaded patch set 2 04/18/19, 08:21
-
TYPO3com voted on patch set 2 V +1 04/18/19, 08:34 Completed build in 13m 27s on Thu, 18 Apr, 10:34 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33331
-
Josef Glatz commented on patch set 2 V -1 CR -1 04/18/19, 13:52
Please have a look at my gif at https://forge.typo3.org/issues/88162?next_issue_id=88161&prev_issue_id=88163#note-4 The UI looks broken if the search result is found on the first line of the content area -
Andreas Kienast commented on patch set 2 04/18/19, 18:21
> Patch Set 2: Verified-1 Code-Review-1 > > Please have a look at my gif at https://forge.typo3.org/issues/88162?next_issue_id=88161&prev_issue_id=88163#note-4 > > The UI looks broken if the search result is found on the first line of the content area Well, that's CodeMirror acting strange here. I can take a look to improve this, but that shouldn't block the patch. -
Josef Glatz voted on patch set 2 V +1 CR +1 04/18/19, 18:28
-
Sven Juergens voted on patch set 2 V +1 CR +1 04/18/19, 19:05
-
Josef Glatz commented on patch set 2 04/19/19, 13:09
I checked it too: it's the default behaviour of code mirror if a search result is found in the first code editor line. On the 2nd look this is fine. Sorry for the first over-hasty "-1" ;-] -
Richard Haeser voted on patch set 2 V +2 CR +2 04/19/19, 14:34
-
Richard Haeser merged patch set 3 04/19/19, 14:35
T3editor.ts:65