Review main Merged

60492[BUGFIX] Store depth selector in workspace module in uc

Benni Mack CR +2 V +2 Easy +5 −6 updated 04/18/19, 07:15

Commit message

The depth selector is now stored in the users' UC, so the Persisent
Storage API can now be used easily.

This way, when changing pages, the depth selector value is kept.

Review

  • Code review CR +2 Done
    • Daniel Sattler +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Daniel Sattler +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/17/19, 16:01

  2. Daniel Goerz voted on patch set 1 V +1 CR +1 04/17/19, 16:04

  3. TYPO3com voted on patch set 1 V +1 04/17/19, 16:15 Completed build in 14m 05s on Wed, 17 Apr, 06:15 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33307

  4. Daniel Sattler voted on patch set 1 V +2 CR +2 04/17/19, 16:55

  5. Daniel Sattler merged patch set 2 04/17/19, 16:56

  6. Daniel Goerz commented on patch set 2 04/17/19, 17:43

  7. Daniel Goerz commented on patch set 2 04/18/19, 07:15

    This implementation also had one new Bug: https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/60508/ We should improve our testing in the future ...