Review main Merged

60497[BUGFIX] Overlay workspace records in Live Search

Benni Mack CR +2 V +2 Easy +6 −17 updated 04/24/19, 18:01

Commit message

The live search in the top right corner should detect and find
records of the current workspace.

A protected method which was unused is also removed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/17/19, 18:41

  2. TYPO3com voted on patch set 1 V +1 04/17/19, 18:53 Completed build in 11m 01s on Wed, 17 Apr, 08:53 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33314

  3. Benni Mack wrote 04/17/19, 20:06

    Topic set to workspaces
  4. Riccardo De Contardi commented on patch set 1 V +1 04/17/19, 21:32

    tested on Master with the following procedure: 1) create a page SITE A; create inside a CE with title siteaa 2) create a page SITE B; create inside a CE with title sitebb 3) switch to draft WS 4) edit page title > SITE A FERRARI; edit CE title > siteaaaferrari 5) edit page title > SITE B LAMBORGHINI; edit CE title > sitebbblamborghini - before patch > titles of both live ad draft workspace are returned - after patch > only the titles pertinent to the workspace (live, draft) are returned
  5. Georg Ringer voted on patch set 1 V +1 CR +1 04/18/19, 03:23

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 04/24/19, 18:01

  7. Daniel Goerz merged patch set 2 04/24/19, 18:01