Review main Merged

60499[BUGFIX] Make filter in workspace module work again

Benni Mack CR +2 V +2 Easy +30 −19 updated 04/25/19, 09:23

Commit message

If no additional fields have been defined, the workspace
module search should use default columns that are shown
by TYPO3 Core.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 04/17/19, 19:16

  2. TYPO3com voted on patch set 1 V +1 04/17/19, 19:29 Completed build in 13m 23s on Wed, 17 Apr, 09:29 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33316

  3. Oliver Hader commented on patch set 1 04/17/19, 19:59

    TYPO3 v7 had these columns: Array ( [label_Workspace] => Array ( [position] => 7 [hidden] => 0 ) [label_Live] => Array ( [position] => 9 [hidden] => 0 ) [label_Stage] => Array ( [position] => 11 [hidden] => 0 ) [languageValue] => Array ( [position] => 14 [hidden] => 0 ) )
  4. Benni Mack wrote 04/17/19, 20:05

    Topic set to workspaces
  5. Daniel Goerz uploaded patch set 2 04/23/19, 08:55

  6. Daniel Goerz commented on patch set 2 V +1 CR +1 04/23/19, 08:56

    Added label_Workspace
  7. TYPO3com voted on patch set 2 V +1 04/23/19, 09:10 Completed build in 14m 36s on Tue, 23 Apr, 11:10 AM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33375

  8. Achim Fritz voted on patch set 2 V +1 CR +1 04/25/19, 06:09

  9. Benni Mack voted on patch set 2 V +2 CR +2 04/25/19, 09:23

  10. Benni Mack merged patch set 3 04/25/19, 09:23