60501[BUGFIX] Have backend layouts in DB respect workspace versions
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Achim Fritz +1
-
Verified V +2 Done
- Susi Moog +2
- Achim Fritz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1825
-
Benni Mack uploaded patch set 1 04/17/19, 19:52
-
Oliver Hader wrote 04/17/19, 20:01
Topic set to workspaces -
TYPO3com voted on patch set 1 V +1 04/17/19, 20:07 Completed build in 14m 47s on Wed, 17 Apr, 10:07 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33318
-
Björn Jacob commented on patch set 1 04/18/19, 05:34
DefaultDataProvider.php:189Please bare with me - since I am not a programmer - but wouldn't be something speaking better? What does "stmt" mean? Is it "statement"? Is it a known abbreviation? I know nitpicking, but just asking and curios :) -
Oliver Klee commented on patch set 1 04/18/19, 10:12
DefaultDataProvider.php:189ReplyI propose $query or $queryResult. -
Oliver Hader commented on patch set 1 04/18/19, 10:26
DefaultDataProvider.php:189Reply UnresolvedIn most cases it is in deed a "Statement", see https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Database/Query/QueryBuilder.php#L176-L178 `$statement` then -
Benni Mack commented on patch set 2 04/18/19, 10:49
Published edit on patch set 1. -
Oliver Klee voted on patch set 2 CR +1 04/18/19, 10:58
-
TYPO3com voted on patch set 2 V +1 04/18/19, 11:06 Completed build in 14m 19s on Thu, 18 Apr, 01:07 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33339
-
Tymoteusz Motylewski commented on patch set 2 04/18/19, 20:43
8.7 not affected or not priority not high enough? -
Benni Mack commented on patch set 2 04/18/19, 21:15
Check the ticket number and you'll know -
Susi Moog commented on patch set 2 V -1 04/18/19, 21:24
workspace be_layouts still show in live be_layout drop down. -
Benni Mack uploaded patch set 3 11/04/19, 20:56
-
TYPO3com voted on patch set 3 V +1 11/04/19, 21:08 Completed build in 11m 37s on Mon, 4 Nov, 09:08 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37993
-
Benni Mack uploaded patch set 4 11/04/19, 21:25
-
TYPO3com voted on patch set 4 V -1 11/04/19, 21:26 Completed build in 11s on Mon, 4 Nov, 09:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37994
-
Benni Mack uploaded patch set 5 11/04/19, 21:28
-
TYPO3com voted on patch set 5 V -1 11/04/19, 21:29 Completed build in 15s on Mon, 4 Nov, 09:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37995
-
Riccardo De Contardi commented on patch set 5 V +1 11/04/19, 22:12
Tested on latest master with the following records - a BE Layout "TEST" created in LIVE workspace (ID=1) - a BE Layout "TEST WS" created in a DRAFT workspace (ID=2) Results *Without the patch:* Both in LIVE and DRAFT workspace, the BE layouts dropdown shows both "TEST" and TEST WS" but the latter is shown _twice_ (!) (with ID=2 and ID=3) *With the patch:*: - LIVE workspace: The dropdown shows only "TEST" - DRAFT workspace The dropdown shows "TEST" and "TEST WS" (not repeated) -
Susi Moog commented on patch set 6 11/05/19, 06:43
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V -1 11/05/19, 06:54 Completed build in 10m 29s on Tue, 5 Nov, 06:54 AM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37996
-
TYPO3com voted on patch set 6 V +1 11/05/19, 09:08 Completed build in 2h 35m 05s on Tue, 5 Nov, 09:08 AM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37996
-
Achim Fritz voted on patch set 6 V +1 CR +1 11/05/19, 09:27
-
Susi Moog voted on patch set 6 V +2 CR +2 11/05/19, 18:50
-
Susi Moog merged patch set 7 11/05/19, 18:51