Review main Merged

60503[BUGFIX] Ensure www.mydomain.com/index.php works

Benni Mack CR +2 V +2 Easy +12 −0 updated 04/18/19, 14:18

Commit message

Calling just "index.php" without "id" and "type" parameter
should work as expected, as before.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Josef Glatz +1
    • Alexander Opitz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Josef Glatz +1
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 04/17/19, 21:17

  2. TYPO3com voted on patch set 1 V +1 04/17/19, 21:31 Completed build in 14m 26s on Wed, 17 Apr, 11:31 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33324

  3. Alexander Opitz commented on patch set 1 V +1 CR +1 04/18/19, 10:35

    This helps for the original report, it doesn't help for the L parameter, maybe another issue, I'm on debugging this.
  4. Benni Mack commented on patch set 1 04/18/19, 10:43

    Hey Alex, there are other open issues / reviews on that, which should be solved differently - see https://review.typo3.org/c/Packages/TYPO3.CMS/+/59891
  5. Alexander Opitz commented on patch set 1 04/18/19, 12:42

    Hi Benni, thx, that's what I searched for.
  6. Josef Glatz voted on patch set 1 V +1 CR +1 04/18/19, 13:12

  7. Josef Glatz commented on patch set 1 04/18/19, 13:15

    just for the records: a trailing "index.php" always removed. Even if I add it to a subpage url. Hreflang and other SEO stuff stay the same.
  8. Susi Moog voted on patch set 1 V +2 CR +2 04/18/19, 14:18

  9. Susi Moog merged patch set 2 04/18/19, 14:18