60504[BUGFIX] Allow URLs to match case-insensitive pages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 89
-
Benni Mack uploaded patch set 1 04/17/19, 21:30
-
TYPO3com voted on patch set 1 V +1 04/17/19, 21:43 Completed build in 13m 04s on Wed, 17 Apr, 11:43 PM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33325
-
Georg Ringer commented on patch set 1 04/18/19, 03:22
should we make this optional? those are different urls and this could hit us later even worse? I remember a setting in Akamai where this was configurable, ignoring case or not -
Georg Ringer voted on patch set 1 CR -1 04/18/19, 07:00
-
Benni Mack commented on patch set 1 04/18/19, 10:54
It is obvious how to fix this. It is however not possible to XCLASS this as the PageUriMatcher is instantiated with "new" instead of makeInstance. On top: Symfony explicitly implement it in a case-sensitive way. However, there are various discussions on the topic: https://stackoverflow.com/questions/7996919/should-url-be-case-sensitive the domain is by standard case-INsensitive, but everything after that can be treated however you want. There is even an Apache2 setting for this. don't know, does not really feel right to me to do it, but I see people writing www.mycompany.com/Products/ instead of /products/. -
Georg Ringer voted on patch set 1 V +1 CR +1 04/18/19, 11:21
-
Josef Glatz commented on patch set 1 V -1 CR -1 04/18/19, 13:05
Applying the patch on 9.5.*@dev and requesting an existing page with slug /veranstaltungen/aktuelle-veranstaltungen/ with curl -I domain.tld/veranstaltungen/aktuelle-veranstaltungeN/ throws an 404 for me. If I manually change the value of pages.slug for the page to /veranstaltungen/aktuelle-veranstaltungeN/ the same 404 occurs if I curl -I domain.tld/veranstaltungen/aktuelle-veranstaltungen/ ------------ Am I doing something wrong in testing the patch? -
Guido Schmechel commented on patch set 1 V -1 04/24/19, 21:16
Same here with master -
Benni Mack abandoned the change 06/06/19, 04:46
does not work. We built a custom middleware to redirect properly to lower-case URLs in our project, if this is necessary.