Review main Merged

60506[BUGFIX] Don't show new button when adding a new record

Benni Mack CR +2 V +2 Easy +16 −14 updated 04/18/19, 14:33

Commit message

As there is no "pid" available, the new button on new
records should not be shown.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 04/17/19, 21:49

  2. TYPO3com voted on patch set 1 V +1 04/17/19, 22:00 Completed build in 11m 33s on Thu, 18 Apr, 12:00 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33327

  3. Josef Glatz voted on patch set 1 V +1 CR +1 04/18/19, 13:43

  4. Susi Moog commented on patch set 1 V +2 CR +2 04/18/19, 14:33

    I'm confused. How is that still a problem? I cannot reproduce the issue, as the new button on new elements asks me to save before being used and if I do that (of course) the pid is then ok. I cannot create a record with missing pid via the button. The button also does not make sense so I'm +1 for it's removal, however I could not reproduce the wrong behaviour.
  5. Susi Moog merged patch set 2 04/18/19, 14:33