Review main Merged

60508[BUGFIX] Make loading of depth in workspace module work for 0

Daniel Goerz CR +2 V +2 Easy +3 −2 updated 04/23/19, 08:38

Commit message

The implementation of storing the depth selection in the
workspace module did not account for the "This site"
option and the according value "0".

With this patch now all options of the depth selector can
be stored and loaded from UC.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Goerz uploaded patch set 1 04/18/19, 07:13

  2. Andreas Kienast voted on patch set 1 CR +1 04/18/19, 07:22

  3. Daniel Goerz wrote 04/18/19, 07:41

    Topic set to Workspaces
  4. Daniel Goerz wrote 04/18/19, 07:41

    Topic changed from Workspaces to workspaces
  5. Achim Fritz voted on patch set 1 V +1 CR +1 04/18/19, 07:52

  6. TYPO3com voted on patch set 1 V +1 04/18/19, 07:56 Completed build in 31m 14s on Thu, 18 Apr, 09:56 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33329

  7. Benni Mack voted on patch set 1 V +2 CR +2 04/23/19, 08:38

  8. Benni Mack merged patch set 2 04/23/19, 08:38