Review main Merged

60509[BUGFIX] Mark symfony/routing 4.2.7 as conflict

Andreas Kienast CR +2 V +2 Easy +7 −5 updated 04/19/19, 05:13

Commit message

Symfony/routing 4.2.7 changed routing behaviour, breaking backwards
compatibility and our implementation. Reported at symfony:

https://github.com/symfony/symfony/pull/31107#issuecomment-484681404

Mark that version as conflict until the behaviour is fixed.

Composer commands:
 - composer update --lock

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2027

Show 12 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/18/19, 08:40

  2. TYPO3com voted on patch set 1 V -1 04/18/19, 08:53 Completed build in 13m 20s on Thu, 18 Apr, 10:53 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33332

  1. Andreas Kienast uploaded patch set 2 04/18/19, 08:57

  2. Josef Glatz commented on patch set 2 04/18/19, 09:01

    for the records: patchset 1 fixed the problem for me in TYPO3 v9.5 instance (Site configuration with activated trailing slash and alternative language with base `/en/`. But I am not able to give a +1 here due to my little knowledge in the TYPO3 routing area.
  3. Oliver Hader commented on patch set 2 CR -1 04/18/19, 09:02

    SiteMatcher.php:129 Unresolved

    When looking to `UrlMatcher` you’ll find `if ('/' === $pathinfo && !$this->allow) {` - which is not possible anymore having the `rtrim` in place)
  4. Oliver Hader commented on patch set 2 04/18/19, 09:03

    In order to verify my last comment, additional tests would be great
  5. TYPO3com voted on patch set 2 V +1 04/18/19, 09:08 Completed build in 10m 36s on Thu, 18 Apr, 11:08 AM Test Summary: 47473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33333

  6. Anja Leichsenring uploaded patch set 3 04/18/19, 10:27

  7. TYPO3com voted on patch set 3 V -1 04/18/19, 10:27 Completed build in 11s on Thu, 18 Apr, 12:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33336

  8. Anja Leichsenring uploaded patch set 4 04/18/19, 10:29

  9. Andreas Kienast updated the commit message in patch set 5 04/18/19, 11:28

  10. TYPO3com voted on patch set 5 V +1 04/18/19, 12:02 Completed build in 25m 54s on Thu, 18 Apr, 02:02 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33343

  11. Josef Glatz commented on patch set 5 04/18/19, 12:19

    Tested patchset 5: with and without trailing slash PageTypeSuffix route enhance configuration in 9.5 LTS. The error when calling domain.tld/en/ still doesn't occur anymore +1 ツ
  12. Alexander Stehlik commented on patch set 5 V +1 CR +1 04/18/19, 13:51

    Works fine with version 10 (with and without trailing slash) but when I try backport it to 9LTS there seems to be another problem: When I configure the language without a trailing slash (e.g. /de) and enter the URL WITH a trailing slash (e.g. /en/) I will be redirected to /en/////// and finally get an internal server error. Entering the URL without a trailing slash works fine.
  13. Andreas Kienast commented on patch set 5 04/18/19, 13:55

    > When I configure the language without a trailing slash (e.g. /de) and enter the URL WITH a trailing slash (e.g. /en/) I will be redirected to /en/////// and finally get an internal server error. Entering the URL without a trailing slash works fine. Hi Alex, this is indeed a different issue and shouldn't be related to this patch.
  14. Josef Glatz commented on patch set 5 V +1 04/18/19, 14:15

    Tested it again with exactly the same results like Alexander: * master: all fine * 9.5.*dev: all fine except if the language base is somehow corrupt ("/de")
  15. Josef Glatz voted on patch set 5 CR +1 04/18/19, 16:21

  16. Manuel Selbach uploaded patch set 6 04/18/19, 16:54

  17. TYPO3com voted on patch set 6 V -1 04/18/19, 17:06 Completed build in 11m 46s on Thu, 18 Apr, 07:06 PM Test Summary: 150 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33349

  18. Susi Moog uploaded patch set 7 04/18/19, 20:51

  19. TYPO3com voted on patch set 7 V -1 04/18/19, 21:02 Completed build in 10m 47s on Thu, 18 Apr, 11:02 PM Test Summary: 8 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33352

  20. TYPO3com voted on patch set 7 V +1 04/18/19, 21:10 Completed build in 29m 10s on Thu, 18 Apr, 11:10 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33352

  21. Benni Mack voted on patch set 7 V +1 CR +1 04/18/19, 21:13

  22. Oliver Klee voted on patch set 7 CR +1 04/18/19, 22:03

  23. Josef Glatz voted on patch set 7 CR +1 04/19/19, 04:52

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 04/19/19, 05:13

  25. Andreas Kienast merged patch set 8 04/19/19, 05:13