Review 9.5 Merged

60512[BUGFIX] Ensure www.mydomain.com/index.php works

Susi Moog CR +2 V +2 Easy +12 −0 updated 06/23/20, 09:30

Commit message

Calling just "index.php" without "id" and "type" parameter
should work as expected, as before.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Alexander Opitz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Susi Moog commented on patch set 1 04/18/19, 14:19

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/18/19, 14:38 Completed build in 19m 25s on Thu, 18 Apr, 04:38 PM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-531

  3. Alexander Opitz voted on patch set 1 V +1 CR +1 04/18/19, 14:39

  4. Susi Moog commented on patch set 1 V +2 CR +2 04/18/19, 14:42

    straight backport, no changes, direct merge.
  5. Susi Moog merged patch set 2 04/18/19, 14:42

  6. Ralf Hübner commented on patch set 2 06/23/20, 09:13

    PageRouter.php:125

    This does not work,if the scriptname looks like "typo3/site/public/index.php" ltrim remove only a trailing "/", but we need the last segment: "index.php" to find and replace the scriptname in the next lines. I test with $scriptName = substr($normalizedParams->getScriptName(), strrpos($normalizedParams->getScriptName(), '/') + 1); and this works in my installation. The resulting $urlPath is empty and that should be the "starting" site.
  7. Ralf Hübner commented on patch set 2 06/23/20, 09:30

    PageRouter.php:125 Reply Unresolved

    Or simplier $scriptName = basename($normalizedParams->getScriptName());