Review 9.5 Merged

60517[BUGFIX] Mark symfony/routing 4.2.7 as conflict

Andreas Kienast CR +2 V +2 Easy +6 −4 updated 04/19/19, 06:28

Commit message

Symfony/routing 4.2.7 changed routing behaviour, breaking backwards
compatibility and our implementation. Reported at symfony:

https://github.com/symfony/symfony/pull/31107#issuecomment-484681404

Mark that version as conflict until the behaviour is fixed.

Composer commands:
 - composer update --lock

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Andreas Kienast uploaded patch set 1 04/19/19, 05:18

  2. Andreas Kienast commented on patch set 1 CR -2 04/19/19, 05:18

    Blocked until https://bamboo.typo3.com/browse/CORE-GTN-748 is successful again.
  3. TYPO3com voted on patch set 1 V +1 04/19/19, 05:43 Completed build in 23m 17s on Fri, 19 Apr, 07:43 AM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-537

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 04/19/19, 06:27

  5. Andreas Kienast merged patch set 2 04/19/19, 06:28