Review main Merged

60518[BUGFIX] Do not remove page cache for redirects issued by plugins

Helmut Hummel CR +2 V +2 Easy +8 −5 updated 05/07/19, 03:30

Commit message

This reverts commit 3139b5608c87e7a5c2a49aa48cc683654db71e39.
"[BUGFIX] Do not cache content with different status code than 200"

At the same time we convert a plugin action to uncached,
in case a redirect is issued.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Helmut Hummel uploaded patch set 1 04/19/19, 13:29

  2. TYPO3com voted on patch set 1 V +1 04/19/19, 13:43 Completed build in 13m 26s on Fri, 19 Apr, 03:43 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33354

  3. Markus Klein commented on patch set 1 CR -1 04/19/19, 15:06

    See my comment in the ticket please.
  4. Helmut Hummel uploaded patch set 2 04/30/19, 15:25

  5. TYPO3com voted on patch set 2 V +1 04/30/19, 15:36 Completed build in 11m 00s on Tue, 30 Apr, 05:36 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33671

  6. Markus Klein commented on patch set 2 04/30/19, 17:16

    Uh... nice idea. Thanks for the update!
  7. Oliver Klee voted on patch set 2 CR +1 05/02/19, 13:06

  8. Andreas Kienast voted on patch set 2 CR +1 05/06/19, 12:50

  9. Susi Moog voted on patch set 2 CR +1 05/06/19, 13:23

  10. Markus Klein commented on patch set 2 V +1 CR +1 05/06/19, 21:23

    works like a charm!
  11. Georg Ringer voted on patch set 2 V +2 CR +2 05/07/19, 03:30

  12. Georg Ringer merged patch set 3 05/07/19, 03:30