Review 9.5 Merged

60519[BUGFIX] Make CodeMirror search persistent

Richard Haeser CR +2 V +2 Easy +3 −1 updated 04/19/19, 18:35

Commit message

Currently, when searching a term in CodeMirror (used in EXT:t3editor),
the search bar disappears when after the operation, which is super
annoying.

The configuration of CodeMirror is slightly changed to keep the
search bar always present until closed explicitly.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Richard Haeser commented on patch set 1 04/19/19, 14:35

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/t3editor/Resources/Public/TypeScript/T3editor.ts
  2. TYPO3com voted on patch set 1 V -1 04/19/19, 14:50 Completed build in 14m 15s on Fri, 19 Apr, 04:50 PM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-539

  3. Andreas Kienast commented on patch set 1 CR -2 04/19/19, 16:02

    The backported TypeScript file is at a wrong location. I will take care of it ASAP.
  4. Andreas Kienast uploaded patch set 2 04/19/19, 18:23

  5. Andreas Kienast voted on patch set 2 CR 0 04/19/19, 18:23

  6. Richard Haeser commented on patch set 2 V +1 CR +1 04/19/19, 18:29

    This change is ready for review.
  7. TYPO3com voted on patch set 2 V +1 04/19/19, 18:33 Completed build in 10m 18s on Fri, 19 Apr, 08:33 PM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-540

  8. Richard Haeser voted on patch set 2 V +2 CR +2 04/19/19, 18:35

  9. Richard Haeser merged patch set 3 04/19/19, 18:35