Review main Merged

60522[TASK] Streamline formatting of html templates

Benjamin Kott CR +2 V +2 Impossible +11618 −11540 updated 04/23/19, 16:01

Commit message

The indentations in the HTML templates are out of control.
Even if we provide an EditorConfig, which should ensure
that the files are all uniformly indented. There seems to
have been an increasing aversion to TABS over time.

This has led to the fact that above all newly created templates
have always been indented with SPACES instead of TABS.
We now have a mix of TABS and SPACES in our project, partly
also in a single file.

To avoid this in the future, all existing templates were converted
to indentations with SPACES and the provided EditorConfig was
adapted. In order to really, really make sure that it doesn't get
out of hand, we also introduce a new linter, which ensures
that all HTML templates are properly indented.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Wand +1
    • Oliver Klee +1
    • Andreas Kienast +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 360

Show 340 more files

Review log 79

  1. Benjamin Kott uploaded patch set 1 04/21/19, 10:20

  2. TYPO3com voted on patch set 1 V -1 04/21/19, 10:34 Completed build in 14m 11s on Sun, 21 Apr, 12:34 PM Test Summary: 1 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33361

  3. TYPO3com voted on patch set 1 V +1 04/21/19, 10:38 Completed build in 32m 18s on Sun, 21 Apr, 12:38 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33361

  4. Oliver Wand voted on patch set 1 CR +1 04/21/19, 12:17

  5. Oliver Klee voted on patch set 1 CR +1 04/21/19, 13:25

  6. Helmut Hummel commented on patch set 1 CR +1 04/21/19, 16:39

    Thanks for indent size 4 :)
  7. Andreas Kienast voted on patch set 1 V +1 CR +1 04/22/19, 13:14

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 04/23/19, 16:01

  9. Anja Leichsenring merged patch set 2 04/23/19, 16:01