Review main Abandoned

60525[WIP][FEATURE] System- and extension-wide Fluid configuration lookup

Claus Due CR 0 V 0 Normal +79 −25 updated 11/09/21, 21:20

Commit message

This patch adds an additional place where Fluid template path
configurations can be stored - and deprecates the way of
setting such paths in TS. Also deprecates the utility methods
on ActionController that only exist to set these paths.

Makes it possible to define layouts, partials and even templates
that are truly global, meaning they are available in any extension
context regardless of which paths were configured for the
extension. This allows the core to ship with a very vanilla content-
and page-implementation in Fluid that can be changed globally
by things like FSC. Users would not know the difference - without
any requirement for configuration they would simply use a layout
name like "Content" and depending on which content rendering
extension is active, the appropriate layout file is selected and used.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Claus Due uploaded patch set 1 04/22/19, 15:10

  2. Claus Due commented on patch set 1 04/22/19, 15:15

    @Alex I'd really like your input on this one - I know you've been thinking about refactoring Extbase config handling to remove the tie-in with TS. This would naturally mean you've also been looking at (similar) ways to put the "view" part of said config, somewhere else. If possible I'd encourage that Extbase completely ignores that Fluid view configuration is even a possibility - and then expect Fluid to simply resolve the right file for the right context. @Benni I'd also like your input on especially two things that this would do: 1) deprecate the TS way of setting paths for Fluid (for plugins; FLUIDTEMPLATE is not adversely affected). And 2) the addition of truly system-wide template files in preparation for shipping vanilla Content, Page etc. layouts with the core and letting exts like FSC ship with their own overrides for these. Obviously those features don't exist yet, there are no default Fluid implementations - but that's another thing I think we should be looking into if we aren't already, and system-wide templates would really kick a lot of the integration concerns to the curb.
  3. TYPO3com voted on patch set 1 V -1 04/22/19, 15:25 Completed build in 15m 10s on Mon, 22 Apr, 05:25 PM Test Summary: 21 of 47862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33371

  4. Christian Kuhn commented on patch set 1 CR -2 11/09/21, 21:20

    Hey. I'm about to abandon this change: Nothing happened here since 2019 and this does not seem to make it as such. Conceptually, I strongly disagree on adding another dependency from ext:fluid to extbase ConfigurationManager (I thingk ConfigurationManager is doomed and must die, I'll continue this path in v12). I agree that the dependency to frontend TypoScript is a nightmare, especially in the backend. (see current page module and dashboard which happily trigger FE TS parsing in backend!). This needs to be removed with fire. I think we *will* have a layer for this - for instance on site level, but binding this to extbase is not the way to go, solutions in this direction will receive -2 from me.
  5. Christian Kuhn abandoned the change 11/09/21, 21:20