Review 9.5 Merged

60535[BUGFIX] Add extension suggestions to EXT:form

Ralf Zimmermann CR +2 V +2 Easy +20 −9 updated 04/25/19, 19:39

Commit message

EXT:form adds a ContextMenu provider which depends on classes of
EXT:filelist. As EXT:filelist is optional in Composer mode, add the
extension as a suggestion and register the ContextMenu provider only in
case the extension is loaded.

Similar guards are added for hooks of EXT:filelist and EXT:impexp.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2

Issues 1

Files 3

Review log 710

  1. Ralf Zimmermann commented on patch set 1 04/24/19, 20:21

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/24/19, 20:38 Completed build in 16m 53s on Wed, 24 Apr, 10:38 PM Test Summary: 50128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-553

  3. Ralf Zimmermann commented on patch set 2 04/25/19, 18:35

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 04/25/19, 18:57 Completed build in 18m 56s on Thu, 25 Apr, 08:57 PM Test Summary: 50128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-565

  5. Mathias Brodala commented on patch set 3 04/25/19, 19:15

    Published edit on patch set 2.
  6. Mathias Brodala commented on patch set 3 04/25/19, 19:16

    Explained justification for "suggest".
  7. Mathias Brodala voted on patch set 3 CR +1 04/25/19, 19:16

  8. Ralf Zimmermann voted on patch set 3 V +2 CR +2 04/25/19, 19:20

  9. Ralf Zimmermann merged patch set 4 04/25/19, 19:20

  10. TYPO3com voted on patch set 3 V +1 04/25/19, 19:39 Completed build in 17m 27s on Thu, 25 Apr, 09:39 PM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-568