Review main Merged

60543[TASK] Transliterate accented characters

Dominik Merkel CR +2 V +2 Easy +20 −2 updated 04/25/19, 17:25

Commit message

Convert accented characters in the form name
to ASCII characters

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Dominik Merkel uploaded patch set 1 04/25/19, 13:29

  2. Oliver Klee commented on patch set 1 CR -1 04/25/19, 13:41

    FormManagerControllerTest.php:406

    Please let's have a separate test for the special characters. This test is about space removal, and the test name and contents should match.
  3. TYPO3com voted on patch set 1 V -1 04/25/19, 13:44 Completed build in 14m 53s on Thu, 25 Apr, 03:44 PM Test Summary: 6 of 47877 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33411

  4. Dominik Merkel uploaded patch set 2 04/25/19, 13:54

  5. TYPO3com voted on patch set 2 V -1 04/25/19, 14:10 Completed build in 15m 25s on Thu, 25 Apr, 04:10 PM Test Summary: 4 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33413

  6. Dominik Merkel uploaded patch set 3 04/25/19, 14:25

  7. TYPO3com voted on patch set 3 V +1 04/25/19, 14:40 Completed build in 14m 54s on Thu, 25 Apr, 04:40 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33415

  8. Oliver Klee voted on patch set 3 CR +1 04/25/19, 17:10

  9. Ralf Zimmermann voted on patch set 3 V +2 CR +2 04/25/19, 17:25

  10. Ralf Zimmermann merged patch set 4 04/25/19, 17:25