Review main Merged

60548[BUGFIX] Use form specific flexform sheets within the frontend

Ralf Zimmermann CR +2 V +2 Hard +318 −21 updated 04/27/19, 19:30

Commit message

Use contextual flexform sheets to identify ext:form finisher overrides
within the frontend.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Susi Moog +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1930

Show 35 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 04/25/19, 15:21

  2. TYPO3com voted on patch set 1 V -1 04/25/19, 15:35 Completed build in 14m 24s on Thu, 25 Apr, 05:35 PM Test Summary: 12 of 47877 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33421

  3. Ralf Zimmermann uploaded patch set 2 04/25/19, 16:55

  4. TYPO3com voted on patch set 2 V -1 04/25/19, 16:55 Completed build in 10s on Thu, 25 Apr, 06:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33426

  5. Ralf Zimmermann uploaded patch set 3 04/25/19, 16:59

  1. TYPO3com commented on patch set 3 04/25/19, 16:59 Completed build in 11s on Thu, 25 Apr, 06:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33427

  2. Ralf Zimmermann uploaded patch set 4 04/25/19, 17:00

  3. Oliver Klee commented on patch set 4 04/25/19, 17:09

    FormFrontendController.php:92

    This method is getting really long. Can we split it up?
  4. TYPO3com voted on patch set 4 V +1 04/25/19, 17:14 Completed build in 14m 25s on Thu, 25 Apr, 07:14 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33428

  5. Ralf Zimmermann uploaded patch set 5 04/25/19, 17:22

  6. TYPO3com voted on patch set 5 V +1 04/25/19, 17:38 Completed build in 15m 11s on Thu, 25 Apr, 07:38 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33430

  7. Susi Moog commented on patch set 5 CR -1 04/25/19, 19:53

    FormFrontendControllerTest.php:34 Unresolved

    can you add an explicit test for the bug case?
  8. Ralf Zimmermann uploaded patch set 6 04/25/19, 20:23

  9. TYPO3com voted on patch set 6 V +1 04/25/19, 20:38 Completed build in 14m 37s on Thu, 25 Apr, 10:38 PM Test Summary: 47492 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33448

  10. Susi Moog voted on patch set 6 V +1 CR +1 04/26/19, 07:20

  11. Ralf Zimmermann commented on patch set 6 CR -1 04/27/19, 10:15

    tmp -1
  12. Ralf Zimmermann uploaded patch set 7 04/27/19, 10:32

  13. TYPO3com voted on patch set 7 V -1 04/27/19, 10:33 Completed build in 07s on Sat, 27 Apr, 12:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33530

  14. Ralf Zimmermann uploaded patch set 8 04/27/19, 15:52

  15. TYPO3com voted on patch set 8 V +1 04/27/19, 16:06 Completed build in 13m 35s on Sat, 27 Apr, 06:06 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33560

  16. Björn Jacob updated the commit message in patch set 9 04/27/19, 16:28

  17. TYPO3com voted on patch set 9 V +1 04/27/19, 16:40 Completed build in 12m 13s on Sat, 27 Apr, 06:40 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33564

  18. Ralf Zimmermann uploaded patch set 10 04/27/19, 16:52

  19. TYPO3com voted on patch set 10 V +1 04/27/19, 17:10 Completed build in 17m 11s on Sat, 27 Apr, 07:10 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33566

  20. Susi Moog voted on patch set 10 V +1 CR +1 04/27/19, 18:22

  21. Mathias Brodala uploaded patch set 11 04/27/19, 18:37

  22. Mathias Brodala voted on patch set 11 V +1 CR +1 04/27/19, 18:38

  23. TYPO3com voted on patch set 11 V +1 04/27/19, 19:07 Completed build in 28m 56s on Sat, 27 Apr, 09:07 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33578

  24. Susi Moog voted on patch set 11 V +2 CR +2 04/27/19, 19:30

  25. Susi Moog merged patch set 12 04/27/19, 19:30