Review main Merged

60556[TASK] Raise twitter bootstrap to 3.4.1

Benni Mack CR +2 V +2 Easy +8 −8 updated 04/26/19, 08:03

Commit message

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.1 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 910

  1. Benni Mack uploaded patch set 1 04/25/19, 19:23

  2. TYPO3com voted on patch set 1 V +1 04/25/19, 19:59 Completed build in 26m 39s on Thu, 25 Apr, 09:59 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33441

  3. Susi Moog voted on patch set 1 CR +1 04/25/19, 20:21

  4. Mathias Brodala voted on patch set 1 CR +1 04/26/19, 07:28

  5. Mathias Brodala voted on patch set 1 V +1 04/26/19, 07:33

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 04/26/19, 07:34

  7. Mathias Brodala commented on patch set 1 04/26/19, 07:35

    Verified by applying the change and checking that the backend looks OK. Do we have locations which would be directly affected, e.g. rich content in tooltips/popovers or something where user input is inserted?
  8. Andreas Kienast commented on patch set 1 04/26/19, 07:40

    > Patch Set 1: > > Verified by applying the change and checking that the backend looks OK. Do we have locations which would be directly affected, e.g. rich content in tooltips/popovers or something where user input is inserted? I'm not aware of such situation where users can have enriched tooltips or popovers.
  9. Andreas Kienast voted on patch set 1 V +2 CR +2 04/26/19, 08:03

  10. Andreas Kienast merged patch set 2 04/26/19, 08:03