Review 9.5 Merged

60560[TASK] Raise twitter bootstrap to 3.4.1

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 04/26/19, 08:26

Commit message

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.1 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast commented on patch set 1 04/26/19, 08:03

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/26/19, 08:18 Completed build in 14m 42s on Fri, 26 Apr, 10:18 AM Test Summary: 50132 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-571

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/26/19, 08:26

  4. Andreas Kienast merged patch set 2 04/26/19, 08:26