60564[TASK] Raise twitter bootstrap to 3.4.1
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1012
-
Andreas Kienast uploaded patch set 1 04/26/19, 08:33
-
Markus Klein commented on patch set 1 04/26/19, 08:45
do we need the wrapper in the install tool too? it wasn't there beforebootstrap.js:20Unresolvedcan this be removed safely? -
Andreas Kienast commented on patch set 1 04/26/19, 09:11
> Patch Set 1: > > (1 comment) > > do we need the wrapper in the install tool too? it wasn't there before The whole file makes no sense, I've pushed another patch that removes that file and uses the one of the core. -
Andreas Kienast uploaded patch set 2 04/26/19, 09:13
-
Andreas Kienast uploaded patch set 3 04/26/19, 09:13
-
Andreas Kienast uploaded patch set 4 04/26/19, 09:15
-
Andreas Kienast uploaded patch set 5 04/26/19, 09:18
-
TYPO3com voted on patch set 1 V +1 04/26/19, 09:21 Completed build in 39m 46s on Fri, 26 Apr, 11:21 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3475
-
Andreas Kienast updated the commit message in patch set 6 04/26/19, 09:33
-
TYPO3com voted on patch set 6 V +1 04/26/19, 10:01 Completed build in 20m 35s on Fri, 26 Apr, 12:01 PM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3481
-
Andreas Kienast voted on patch set 6 V +2 CR +2 04/26/19, 10:03
-
Andreas Kienast merged patch set 7 04/26/19, 10:03