Review main Merged

60568[BUGFIX] Check existence of properties before usage

Susi Moog CR +2 V +2 Normal +105 −7 updated 04/29/19, 06:00

Commit message

The ImageViewHelper uses properties 'title' and 'alternative' from file
without checking whether they exist or not. This results in an
exception for example with freshly uploaded files.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Ralf Zimmermann +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2128

Show 3 earlier messages
  1. Susi Moog uploaded patch set 1 04/26/19, 10:54

  2. Susi Moog commented on patch set 1 04/26/19, 10:55

    Happens only on master as the meta data handling was changed a bit.
  3. Susi Moog uploaded patch set 2 04/26/19, 11:00

  1. Mathias Brodala commented on patch set 3 04/26/19, 11:09

    Published edit on patch set 2.
  2. Mathias Brodala commented on patch set 3 V +1 CR +1 04/26/19, 11:12

  3. TYPO3com voted on patch set 1 V -1 04/26/19, 11:19 Completed build in 17m 40s on Fri, 26 Apr, 01:19 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33474

  4. Ralf Zimmermann voted on patch set 3 V +1 CR +1 04/26/19, 11:24

  5. TYPO3com voted on patch set 2 V -1 04/26/19, 11:24 Completed build in 22m 13s on Fri, 26 Apr, 01:24 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33475

  6. TYPO3com voted on patch set 3 V -1 04/26/19, 11:27 Completed build in 13m 21s on Fri, 26 Apr, 01:27 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33476

  7. Susi Moog uploaded patch set 4 04/26/19, 11:30

  8. Oliver Klee commented on patch set 4 CR -1 04/26/19, 11:33

    ImageViewHelperTest.php:136

    We also need regression tests that fail without the fix.
  9. Oliver Klee commented on patch set 4 04/26/19, 11:33

    Is 9.5 affected as well?
  10. Susi Moog commented on patch set 4 04/26/19, 11:34

    Reply

    no, see first comment.
  11. Susi Moog uploaded patch set 5 04/26/19, 11:40

  12. Susi Moog commented on patch set 5 04/26/19, 11:41

    ImageViewHelperTest.php:136 Reply

    Done
  13. TYPO3com voted on patch set 4 V +1 04/26/19, 11:44 Completed build in 13m 48s on Fri, 26 Apr, 01:44 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33477

  14. Oliver Klee voted on patch set 5 CR +1 04/26/19, 11:48

  15. TYPO3com voted on patch set 5 V -1 04/26/19, 11:51 Completed build in 10m 32s on Fri, 26 Apr, 01:51 PM Test Summary: 8 of 47889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33478

  16. Susi Moog uploaded patch set 6 04/26/19, 12:06

  17. Oliver Klee voted on patch set 6 CR +1 04/26/19, 12:21

  18. TYPO3com voted on patch set 6 V -1 04/26/19, 12:28 Completed build in 18m 30s on Fri, 26 Apr, 02:28 PM Test Summary: 47496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33482

  19. Susi Moog uploaded patch set 7 04/26/19, 13:21

  20. TYPO3com voted on patch set 7 V +1 04/26/19, 13:34 Completed build in 11m 59s on Fri, 26 Apr, 03:34 PM Test Summary: 47496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33489

  21. Oliver Klee voted on patch set 7 CR +1 04/26/19, 14:52

  22. Willi Wehmeier voted on patch set 7 CR +1 04/29/19, 05:33

  23. Ralf Zimmermann voted on patch set 7 V +1 CR +1 04/29/19, 05:43

  24. Georg Ringer voted on patch set 7 V +2 CR +2 04/29/19, 06:00

  25. Georg Ringer merged patch set 8 04/29/19, 06:00