60568[BUGFIX] Check existence of properties before usage
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Ralf Zimmermann +1
- Willi Wehmeier +1
-
Verified V +2 Done
- Georg Ringer +2
- Ralf Zimmermann +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2128
Show 3 earlier messages
-
Mathias Brodala commented on patch set 3 04/26/19, 11:09
Published edit on patch set 2. -
Mathias Brodala commented on patch set 3 V +1 CR +1 04/26/19, 11:12
Works now together with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60567 -
TYPO3com voted on patch set 1 V -1 04/26/19, 11:19 Completed build in 17m 40s on Fri, 26 Apr, 01:19 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33474
-
Ralf Zimmermann voted on patch set 3 V +1 CR +1 04/26/19, 11:24
-
TYPO3com voted on patch set 2 V -1 04/26/19, 11:24 Completed build in 22m 13s on Fri, 26 Apr, 01:24 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33475
-
TYPO3com voted on patch set 3 V -1 04/26/19, 11:27 Completed build in 13m 21s on Fri, 26 Apr, 01:27 PM Test Summary: 8 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33476
-
Susi Moog uploaded patch set 4 04/26/19, 11:30
-
Oliver Klee commented on patch set 4 CR -1 04/26/19, 11:33
ImageViewHelperTest.php:136We also need regression tests that fail without the fix. -
Oliver Klee commented on patch set 4 04/26/19, 11:33
Is 9.5 affected as well? -
Susi Moog commented on patch set 4 04/26/19, 11:34
Reply
no, see first comment. -
Susi Moog uploaded patch set 5 04/26/19, 11:40
-
Susi Moog commented on patch set 5 04/26/19, 11:41
ImageViewHelperTest.php:136ReplyDone -
TYPO3com voted on patch set 4 V +1 04/26/19, 11:44 Completed build in 13m 48s on Fri, 26 Apr, 01:44 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33477
-
Oliver Klee voted on patch set 5 CR +1 04/26/19, 11:48
-
TYPO3com voted on patch set 5 V -1 04/26/19, 11:51 Completed build in 10m 32s on Fri, 26 Apr, 01:51 PM Test Summary: 8 of 47889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33478
-
Susi Moog uploaded patch set 6 04/26/19, 12:06
-
Oliver Klee voted on patch set 6 CR +1 04/26/19, 12:21
-
TYPO3com voted on patch set 6 V -1 04/26/19, 12:28 Completed build in 18m 30s on Fri, 26 Apr, 02:28 PM Test Summary: 47496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33482
-
Susi Moog uploaded patch set 7 04/26/19, 13:21
-
TYPO3com voted on patch set 7 V +1 04/26/19, 13:34 Completed build in 11m 59s on Fri, 26 Apr, 03:34 PM Test Summary: 47496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33489
-
Oliver Klee voted on patch set 7 CR +1 04/26/19, 14:52
-
Willi Wehmeier voted on patch set 7 CR +1 04/29/19, 05:33
-
Ralf Zimmermann voted on patch set 7 V +1 CR +1 04/29/19, 05:43
-
Georg Ringer voted on patch set 7 V +2 CR +2 04/29/19, 06:00
-
Georg Ringer merged patch set 8 04/29/19, 06:00