Review main Merged

60570[TASK] Avoid pointless finisher override checkbox

Michael Waack CR +2 V +2 Normal +42 −20 updated 04/27/19, 20:52

Commit message

The form plugin now only renders the checkbox for overriding
the finishers if finishers are available at all. Also finishers
without options are ignored.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Dominik Merkel +1
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Dominik Merkel +1
    • Björn Jacob +1
    • Mathias Brodala +1

Issues 1

Files 3

Review log 1522

  1. Michael Waack uploaded patch set 1 04/26/19, 11:58

  2. TYPO3com voted on patch set 1 V +1 04/26/19, 12:15 Completed build in 17m 05s on Fri, 26 Apr, 02:15 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33480

  3. Michael Waack uploaded patch set 2 04/26/19, 12:16

  4. TYPO3com commented on patch set 2 04/26/19, 12:33 Completed build in 13m 38s on Fri, 26 Apr, 02:33 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33484

  5. Björn Jacob updated the commit message in patch set 3 04/26/19, 13:45

  6. TYPO3com voted on patch set 3 V +1 04/26/19, 14:01 Completed build in 15m 36s on Fri, 26 Apr, 04:01 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33494

  7. Mathias Brodala updated the commit message in patch set 4 04/26/19, 17:19

  8. TYPO3com voted on patch set 4 V +1 04/26/19, 17:40 Completed build in 19m 31s on Fri, 26 Apr, 07:40 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33510

  9. Ralf Zimmermann commented on patch set 4 CR -1 04/27/19, 08:14

  10. Ralf Zimmermann voted on patch set 4 CR 0 04/27/19, 19:50

  11. Mathias Brodala uploaded patch set 5 04/27/19, 20:04

  12. TYPO3com voted on patch set 5 V +1 04/27/19, 20:21 Completed build in 14m 42s on Sat, 27 Apr, 10:21 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33584

  13. Susi Moog commented on patch set 5 CR -1 04/27/19, 20:24

    Mathias will fix it.
  14. Mathias Brodala uploaded patch set 6 04/27/19, 20:24

  15. Mathias Brodala uploaded patch set 7 04/27/19, 20:27

  16. Mathias Brodala voted on patch set 7 V +1 CR +1 04/27/19, 20:30

  17. Björn Jacob voted on patch set 7 V +1 CR +1 04/27/19, 20:32

  18. Dominik Merkel voted on patch set 7 V +1 CR +1 04/27/19, 20:40

  19. TYPO3com voted on patch set 6 V +1 04/27/19, 20:41 Completed build in 16m 47s on Sat, 27 Apr, 10:41 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33586

  20. Ralf Zimmermann voted on patch set 7 V +2 CR +2 04/27/19, 20:43

  21. Ralf Zimmermann merged patch set 8 04/27/19, 20:43

  22. TYPO3com voted on patch set 7 V +1 04/27/19, 20:52 Completed build in 23m 20s on Sat, 27 Apr, 10:52 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33587