Review main Merged

60582[FEATURE] Double click in structure tree changes label

Dominik Merkel CR +2 V +2 Normal +112 −1 updated 04/28/19, 15:24

Commit message

A new convenience function has been integrated which allows the user to
change the label of an element within the structure tree.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Susi Moog +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1927

Show 12 earlier messages
  1. Dominik Merkel uploaded patch set 1 04/27/19, 07:54

  2. TYPO3com voted on patch set 1 V +1 04/27/19, 08:08 Completed build in 13m 53s on Sat, 27 Apr, 10:08 AM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33514

  1. Björn Jacob updated the commit message in patch set 2 04/28/19, 13:21

  2. Björn Jacob updated the commit message in patch set 3 04/28/19, 13:22

  3. TYPO3com voted on patch set 2 V +1 04/28/19, 13:36 Completed build in 15m 05s on Sun, 28 Apr, 03:36 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33624

  4. TYPO3com voted on patch set 3 V +1 04/28/19, 13:37 Completed build in 15m 00s on Sun, 28 Apr, 03:37 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33625

  5. Dominik Merkel uploaded patch set 4 04/28/19, 13:40

  6. Dominik Merkel commented on patch set 4 04/28/19, 13:42

    This change is ready for review.
  7. Dominik Merkel uploaded patch set 5 04/28/19, 13:46

  8. TYPO3com voted on patch set 4 V +1 04/28/19, 13:59 Completed build in 18m 30s on Sun, 28 Apr, 03:59 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33626

  9. Björn Jacob commented on patch set 5 CR -1 04/28/19, 14:01

    On it
  10. Björn Jacob commented on patch set 6 04/28/19, 14:03

    Published edit on patch set 5.
  11. Björn Jacob voted on patch set 6 V +1 CR +1 04/28/19, 14:04

  12. TYPO3com voted on patch set 5 V +1 04/28/19, 14:13 Completed build in 26m 42s on Sun, 28 Apr, 04:13 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33629

  13. Mathias Brodala commented on patch set 6 CR -1 04/28/19, 14:37

    Feature-84757-DoubleClickInStructureTreeChangesLabel.rst:12

    This should be rephrase to follow the usual wording. This file is no user story. 😉

    TreeComponent.js:492

    Can't we use the native double click event?

    TreeComponent.js:673

    You can use KeyEvent constants here IIRC
  14. TYPO3com voted on patch set 6 V -1 04/28/19, 14:37 Completed build in 20m 10s on Sun, 28 Apr, 04:37 PM Test Summary: 9 of 47857 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33634

  15. TYPO3com voted on patch set 6 V +1 04/28/19, 14:46 Completed build in 48m 54s on Sun, 28 Apr, 04:46 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33634

  16. Ralf Zimmermann uploaded patch set 7 04/28/19, 14:49

  17. Ralf Zimmermann commented on patch set 7 04/28/19, 14:50

    TreeComponent.js:492 Reply

    Done
  18. Susi Moog commented on patch set 8 04/28/19, 14:56

    Published edit on patch set 7.
  19. Ralf Zimmermann commented on patch set 8 04/28/19, 14:59

    TreeComponent.js:673 Reply

    The compatibility is not the best: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code#Browser_compatibility we should not make use of this at this time.
  20. Ralf Zimmermann commented on patch set 9 04/28/19, 15:04

    Published edit on patch set 8.
  21. Mathias Brodala commented on patch set 9 04/28/19, 15:10

    Feature-84757-DoubleClickInStructureTreeChangesLabel.rst:12 Reply

    Done

    TreeComponent.js:492 Reply

    Ack

    TreeComponent.js:673 Reply

    Ack
  22. TYPO3com voted on patch set 9 V +1 04/28/19, 15:23 Completed build in 17m 11s on Sun, 28 Apr, 05:23 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33641

  23. Susi Moog voted on patch set 9 V +1 CR +1 04/28/19, 15:24

  24. Ralf Zimmermann voted on patch set 9 V +2 CR +2 04/28/19, 15:24

  25. Ralf Zimmermann merged patch set 10 04/28/19, 15:24