Review main Merged

60588[BUGFIX] Add id to confirmation finisher template

Dominik Merkel CR +2 V +2 Easy +10 −8 updated 04/27/19, 13:51

Commit message

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Dominik Merkel uploaded patch set 1 04/27/19, 12:06

  2. TYPO3com voted on patch set 1 V +1 04/27/19, 12:19 Completed build in 13m 37s on Sat, 27 Apr, 02:19 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33536

  3. Mathias Brodala commented on patch set 1 04/27/19, 12:31

    Confirmation.html:2 Unresolved

    This must also include the content element UID IIRC, otherwise using the same form twice on a page will lead to duplicate IDs.
  4. Ralf Zimmermann commented on patch set 1 04/27/19, 12:52

    the content element id is already included (through frontend controller)
  5. Dominik Merkel updated the commit message in patch set 2 04/27/19, 13:06

  6. Mathias Brodala uploaded patch set 3 04/27/19, 13:14

  7. Mathias Brodala commented on patch set 3 V +1 CR +1 04/27/19, 13:14

    Switched to "{form.identifier}" similar to "Form.html"
  8. Dominik Merkel updated the commit message in patch set 4 04/27/19, 13:14

  9. Mathias Brodala voted on patch set 4 V +1 CR +1 04/27/19, 13:16

  10. TYPO3com voted on patch set 2 V +1 04/27/19, 13:27 Completed build in 16m 07s on Sat, 27 Apr, 03:27 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33541

  11. TYPO3com voted on patch set 3 V +1 04/27/19, 13:38 Completed build in 17m 26s on Sat, 27 Apr, 03:38 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33543

  12. TYPO3com voted on patch set 4 V +1 04/27/19, 13:44 Completed build in 23m 21s on Sat, 27 Apr, 03:44 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33544

  13. Ralf Zimmermann voted on patch set 4 V +2 CR +2 04/27/19, 13:51

  14. Ralf Zimmermann merged patch set 5 04/27/19, 13:51