Review main Merged

60595[TASK] Display max file size hint

Susi Moog CR +2 V +2 Normal +105 −2 updated 04/27/19, 19:58

Commit message

When configuring a form with a file size validator it can be helpful to
know what the servers' max upload capabilities are. As it may make sense
to set bigger values and then contact a server admin to adjust the
server settings, we do not want to restrict the input field. Instead,
a hint with the current configuration has been added to inform the
editor / integrator of the current limitations.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Dominik Merkel +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 813

  1. Susi Moog uploaded patch set 1 04/27/19, 14:34

  2. Susi Moog uploaded patch set 2 04/27/19, 14:35

  3. TYPO3com voted on patch set 1 V +1 04/27/19, 14:46 Completed build in 12m 10s on Sat, 27 Apr, 04:46 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33550

  4. TYPO3com voted on patch set 2 V -1 04/27/19, 14:53 Completed build in 18m 01s on Sat, 27 Apr, 04:53 PM Test Summary: 2 of 47881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33551

  5. Susi Moog uploaded patch set 3 04/27/19, 15:05

  6. TYPO3com voted on patch set 3 V +1 04/27/19, 15:21 Completed build in 13m 43s on Sat, 27 Apr, 05:21 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33556

  7. Ralf Zimmermann uploaded patch set 4 04/27/19, 16:20

  8. TYPO3com voted on patch set 4 V -1 04/27/19, 16:33 Completed build in 12m 42s on Sat, 27 Apr, 06:33 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33562

  9. Susi Moog commented on patch set 5 04/27/19, 16:52

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V +1 04/27/19, 17:10 Completed build in 17m 41s on Sat, 27 Apr, 07:10 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33565

  11. Dominik Merkel voted on patch set 5 V +1 04/27/19, 19:49

  12. Ralf Zimmermann voted on patch set 5 V +2 CR +2 04/27/19, 19:58

  13. Ralf Zimmermann merged patch set 6 04/27/19, 19:58