Review main Merged

60596[BUGFIX] Add guard clause to preFileAdd form hook

Susi Moog CR +2 V +2 Easy +6 −0 updated 04/27/19, 18:28

Commit message

With the security fix in #f3445f964 checks on EXT:form file handling
were added to ensure secure form definition files. These checks are
based on FAL hooks. One of these - preFileAdd - contains checks based
on the content of the file to add, to do that, the file content is
fetched via file_get_contents. Due to a missing guard this was executed
for all file add operations instead of only for form definitions
resulting in performance loss and high memory usage. The check has
now been implemented.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Dominik Merkel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Dominik Merkel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Susi Moog uploaded patch set 1 04/27/19, 14:58

  2. TYPO3com voted on patch set 1 V +1 04/27/19, 15:15 Completed build in 17m 28s on Sat, 27 Apr, 05:15 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33554

  3. Oliver Hader voted on patch set 1 CR +1 04/27/19, 16:38

  4. Dominik Merkel voted on patch set 1 V +1 CR +1 04/27/19, 18:26

  5. Ralf Zimmermann voted on patch set 1 V +2 CR +2 04/27/19, 18:28

  6. Ralf Zimmermann merged patch set 2 04/27/19, 18:28