Review 9.5 Merged

60603[BUGFIX] Add guard clause to preFileAdd form hook

Ralf Zimmermann CR +2 V +2 Easy +6 −0 updated 04/27/19, 19:36

Commit message

With the security fix in #f3445f964 checks on EXT:form file handling
were added to ensure secure form definition files. These checks are
based on FAL hooks. One of these - preFileAdd - contains checks based
on the content of the file to add, to do that, the file content is
fetched via file_get_contents. Due to a missing guard this was executed
for all file add operations instead of only for form definitions
resulting in performance loss and high memory usage. The check has
now been implemented.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Ralf Zimmermann commented on patch set 1 04/27/19, 18:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/27/19, 18:54 Completed build in 16m 07s on Sat, 27 Apr, 08:54 PM Test Summary: 50104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-601

  3. Ralf Zimmermann voted on patch set 1 V +2 CR +2 04/27/19, 19:35

  4. Ralf Zimmermann merged patch set 2 04/27/19, 19:36